Commit

Author: dajimenezriv-internxt

dist/addon.node

@@ -2,12 +2,12 @@
 
 #include <node_api.h>
 
-napi_value CreatePlaceholderFile(napi_env env, napi_callback_info args);
+napi_value CreateFilePlaceholderWrapper(napi_env env, napi_callback_info args);
+napi_value CreateFolderPlaceholderWrapper(napi_env env, napi_callback_info args);
 napi_value UnregisterSyncRootWrapper(napi_env env, napi_callback_info args);
 napi_value RegisterSyncRootWrapper(napi_env env, napi_callback_info args);
 napi_value GetRegisteredSyncRootsWrapper(napi_env env, napi_callback_info args);
 napi_value ConnectSyncRootWrapper(napi_env env, napi_callback_info args);
-napi_value CreateEntryWrapper(napi_env env, napi_callback_info args);
 napi_value DisconnectSyncRootWrapper(napi_env env, napi_callback_info args);
 napi_value GetFileIdentityWrapper(napi_env env, napi_callback_info args);
 napi_value addLoggerPathWrapper(napi_env env, napi_callback_info args);

include/virtual_drive/Wrappers.h

@@ -4,9 +4,9 @@
 napi_value init(napi_env env, napi_value exports)
 {
   napi_property_descriptor desc = {
-      "createPlaceholderFile",
+      "createFilePlaceholder",
       nullptr,
-      CreatePlaceholderFile,
+      CreateFilePlaceholderWrapper,
       nullptr,
       nullptr,
       nullptr,
@@ -88,20 +88,20 @@ napi_value init(napi_env env, napi_value exports)
     return nullptr;
   }
 
-  napi_property_descriptor createEntryDesc = {
-      "createEntry",
+  napi_property_descriptor createFolderPlaceholderDesc = {
+      "createFolderPlaceholder",
       nullptr,
-      CreateEntryWrapper,
+      CreateFolderPlaceholderWrapper,
       nullptr,
       nullptr,
       nullptr,
       napi_default,
       nullptr};
 
-  napi_status defineCreateEntryStatus = napi_define_properties(env, exports, 1, &createEntryDesc);
-  if (defineCreateEntryStatus != napi_ok)
+  napi_status defineCreateFolderPlaceholderStatus = napi_define_properties(env, exports, 1, &createFolderPlaceholderDesc);
+  if (defineCreateFolderPlaceholderStatus != napi_ok)
   {
-    napi_throw_error(env, nullptr, "Failed to define createEntry function");
+    napi_throw_error(env, nullptr, "Failed to define createFolderPlaceholder function");
     return nullptr;
   }
 

native-src/main.cpp

@@ -91,10 +91,6 @@ void Placeholders::ConvertToPlaceholder(const std::wstring &path, const std::wst
     if (hr != 0x8007017C) {
         winrt::check_hresult(hr);
     }
-
-    // if (!isDirectory) {
-    //     winrt::check_hresult(CfSetPinState(fileHandle.get(), CF_PIN_STATE_PINNED, CF_SET_PIN_FLAG_NONE, nullptr));
-    // }
 }
 
 /**

native-src/placeholders_interface/Planceholders.cpp

@@ -23,7 +23,7 @@
 #include "update_sync_status_wrapper.h"
 #include "NAPI_SAFE_WRAP.h"
 
-napi_value CreatePlaceholderFile(napi_env env, napi_callback_info args) {
+napi_value CreateFilePlaceholderWrapper(napi_env env, napi_callback_info args) {
     return NAPI_SAFE_WRAP(env, args, create_file_placeholder_impl);
 }
 
@@ -43,7 +43,7 @@ napi_value ConnectSyncRootWrapper(napi_env env, napi_callback_info args) {
     return NAPI_SAFE_WRAP(env, args, connect_sync_root_impl);
 }
 
-napi_value CreateEntryWrapper(napi_env env, napi_callback_info args) {
+napi_value CreateFolderPlaceholderWrapper(napi_env env, napi_callback_info args) {
     return NAPI_SAFE_WRAP(env, args, create_folder_placeholder_impl);
 }
 

native-src/virtual_drive/Wrappers.cpp

@@ -6,14 +6,14 @@
 
 napi_value create_file_placeholder_impl(napi_env env, napi_callback_info info)
 {
-    auto [fileName, placeholderId, fileSize, creationTimeMs, lastWriteTimeMs, lastAccessTimeMs, parentPath] =
+    auto [name, placeholderId, fileSize, creationTimeMs, lastWriteTimeMs, lastAccessTimeMs, parentPath] =
         napi_extract_args<std::wstring, std::wstring, int64_t, int64_t, int64_t, int64_t, std::wstring>(env, info);
 
     LARGE_INTEGER creationTime = Utilities::JsTimestampToLargeInteger(creationTimeMs);
     LARGE_INTEGER lastWriteTime = Utilities::JsTimestampToLargeInteger(lastWriteTimeMs);
     LARGE_INTEGER lastAccessTime = Utilities::JsTimestampToLargeInteger(lastAccessTimeMs);
 
-    std::wstring path = parentPath + L'\\' + fileName;
+    std::wstring path = parentPath + L'\\' + name;
 
     if (std::filesystem::exists(path)) {
         Placeholders::ConvertToPlaceholder(path, placeholderId);
@@ -24,7 +24,7 @@ napi_value create_file_placeholder_impl(napi_env env, napi_callback_info info)
     CF_PLACEHOLDER_CREATE_INFO cloudEntry = {};
     cloudEntry.FileIdentity = placeholderId.c_str();
     cloudEntry.FileIdentityLength = static_cast<DWORD>((placeholderId.size() + 1) * sizeof(WCHAR));
-    cloudEntry.RelativeFileName = fileName.c_str();
+    cloudEntry.RelativeFileName = name.c_str();
     cloudEntry.Flags = CF_PLACEHOLDER_CREATE_FLAG_MARK_IN_SYNC;
     cloudEntry.FsMetadata.FileSize.QuadPart = fileSize;
     cloudEntry.FsMetadata.BasicInfo.FileAttributes = FILE_ATTRIBUTE_NORMAL;

native-src/virtual_drive/create_file_placeholder.cpp

@@ -6,14 +6,14 @@
 
 napi_value create_folder_placeholder_impl(napi_env env, napi_callback_info info)
 {
-    auto [folderName, placeholderId, creationTimeMs, lastWriteTimeMs, lastAccessTimeMs, parentPath] =
+    auto [name, placeholderId, creationTimeMs, lastWriteTimeMs, lastAccessTimeMs, parentPath] =
         napi_extract_args<std::wstring, std::wstring, int64_t, int64_t, int64_t, std::wstring>(env, info);
 
     LARGE_INTEGER creationTime = Utilities::JsTimestampToLargeInteger(creationTimeMs);
     LARGE_INTEGER lastWriteTime = Utilities::JsTimestampToLargeInteger(lastWriteTimeMs);
     LARGE_INTEGER lastAccessTime = Utilities::JsTimestampToLargeInteger(lastAccessTimeMs);
 
-    std::wstring path = parentPath + L"\\" + folderName;
+    std::wstring path = parentPath + L'\\' + name;
 
     if (std::filesystem::exists(path)) {
         Placeholders::ConvertToPlaceholder(path, placeholderId);
@@ -24,7 +24,7 @@ napi_value create_folder_placeholder_impl(napi_env env, napi_callback_info info)
     CF_PLACEHOLDER_CREATE_INFO cloudEntry = {};
     cloudEntry.FileIdentity = placeholderId.c_str();
     cloudEntry.FileIdentityLength = static_cast<DWORD>((placeholderId.size() + 1) * sizeof(WCHAR));
-    cloudEntry.RelativeFileName = folderName.c_str();
+    cloudEntry.RelativeFileName = name.c_str();
     cloudEntry.Flags = CF_PLACEHOLDER_CREATE_FLAG_DISABLE_ON_DEMAND_POPULATION; // Deactivate download on demand
     cloudEntry.FsMetadata.BasicInfo.FileAttributes = FILE_ATTRIBUTE_DIRECTORY;
     cloudEntry.FsMetadata.BasicInfo.CreationTime = creationTime;