Remove rename or move from C++ (#176)

dajimenezriv-internxt · web-flow · commit 7195ba067264 · 2025-07-10T15:57:20.000+02:00
* Remove rename from C++

* Update package.json
diff --git a/binding.gyp b/binding.gyp
@@ -28,8 +28,6 @@
         "native-src/sync_root_interface/callbacks/FetchData/TransferContext.cpp",
         "native-src/sync_root_interface/callbacks/FetchPlaceholder/FetchPlaceholder.cpp",
         "native-src/sync_root_interface/callbacks/NotifyDelete/NotifyDeleteCallback.cpp",
-        "native-src/sync_root_interface/callbacks/NotifyRename/NotifyRenameCallback.cpp",
-        "native-src/sync_root_interface/callbacks/NotifyRename/RenameTransferContext.cpp",
         "native-src/virtual_drive/Wrappers.cpp"
       ],
       "include_dirs": [
diff --git a/dist/addon.node b/dist/addon.node
diff --git a/include/sync_root_interface/RenameTransferContext.h b/include/sync_root_interface/RenameTransferContext.h
diff --git a/include/sync_root_interface/callbacks/Callbacks.h b/include/sync_root_interface/callbacks/Callbacks.h
@@ -8,10 +8,6 @@ void register_threadsafe_callbacks(napi_env env, InputSyncCallbacks input);
 void register_threadsafe_notify_delete_callback(const std::string &resource_name, napi_env env, InputSyncCallbacks input);
 void CALLBACK notify_delete_callback_wrapper(_In_ CONST CF_CALLBACK_INFO *callbackInfo, _In_ CONST CF_CALLBACK_PARAMETERS *callbackParameters);
 
-// Rename Callback
-void register_threadsafe_notify_rename_callback(const std::string &resource_name, napi_env env, InputSyncCallbacks input);
-void CALLBACK notify_rename_callback_wrapper(_In_ CONST CF_CALLBACK_INFO *callbackInfo, _In_ CONST CF_CALLBACK_PARAMETERS *callbackParameters);
-
 // Fetch Placeholders Callback
 void register_threadsafe_fetch_placeholders_callback(const std::string &resource_name, napi_env env, InputSyncCallbacks input);
 void CALLBACK fetch_placeholders_callback_wrapper(_In_ CONST CF_CALLBACK_INFO *callbackInfo, _In_ CONST CF_CALLBACK_PARAMETERS *callbackParameters);
diff --git a/include/sync_root_interface/callbacks/CallbacksContext.h b/include/sync_root_interface/callbacks/CallbacksContext.h
@@ -21,7 +21,5 @@ struct InputSyncCallbacks {
     napi_ref notify_dehydrate_completion_callback_ref;
     napi_ref notify_delete_callback_ref;
     napi_ref notify_delete_completion_callback_ref;
-    napi_ref notify_rename_callback_ref;
-    napi_ref notify_rename_completion_callback_ref;
     napi_ref none_callback_ref;
 };
diff --git a/include/types/ProcessTypes.h b/include/types/ProcessTypes.h
@@ -17,7 +17,6 @@ enum class FileOperationError
 {
     UPLOAD_ERROR,
     DOWNLOAD_ERROR,
-    RENAME_ERROR,
     DELETE_ERROR,
     METADATA_READ_ERROR
 };
diff --git a/native-src/sync_root_interface/SyncRoot.cpp b/native-src/sync_root_interface/SyncRoot.cpp
@@ -258,7 +258,6 @@ HRESULT SyncRoot::ConnectSyncRoot(const wchar_t *syncRootPath, InputSyncCallback
 
         CF_CALLBACK_REGISTRATION callbackTable[] = {
             {CF_CALLBACK_TYPE_NOTIFY_DELETE, notify_delete_callback_wrapper},
-            {CF_CALLBACK_TYPE_NOTIFY_RENAME, notify_rename_callback_wrapper},
             {CF_CALLBACK_TYPE_FETCH_PLACEHOLDERS, fetch_placeholders_callback_wrapper},
             {CF_CALLBACK_TYPE_FETCH_DATA, fetch_data_callback_wrapper},
             {CF_CALLBACK_TYPE_CANCEL_FETCH_DATA, cancel_fetch_data_callback_wrapper},
diff --git a/native-src/sync_root_interface/Utilities.cpp b/native-src/sync_root_interface/Utilities.cpp
@@ -278,8 +278,6 @@ std::wstring Utilities::FileOperationErrorToWString(FileOperationError error)
         return L"UPLOAD_ERROR";
     case FileOperationError::DOWNLOAD_ERROR:
         return L"DOWNLOAD_ERROR";
-    case FileOperationError::RENAME_ERROR:
-        return L"RENAME_ERROR";
     case FileOperationError::DELETE_ERROR:
         return L"DELETE_ERROR";
     case FileOperationError::METADATA_READ_ERROR:
diff --git a/native-src/sync_root_interface/callbacks/Callbacks.cpp b/native-src/sync_root_interface/callbacks/Callbacks.cpp
@@ -4,7 +4,6 @@
 void register_threadsafe_callbacks(napi_env env, InputSyncCallbacks input)
 {
     register_threadsafe_notify_delete_callback("NotifyDeleteThreadSafe", env, input);
-    register_threadsafe_notify_rename_callback("NotifyRenameThreadSafe", env, input);
     register_threadsafe_fetch_data_callback("FetchDataThreadSafe", env, input);
     register_threadsafe_cancel_fetch_data_callback("CancelFetchDataThreadSafe", env, input);
 }
diff --git a/native-src/sync_root_interface/callbacks/NotifyRename/NotifyRenameCallback.cpp b/native-src/sync_root_interface/callbacks/NotifyRename/NotifyRenameCallback.cpp
diff --git a/native-src/sync_root_interface/callbacks/NotifyRename/RenameTransferContext.cpp b/native-src/sync_root_interface/callbacks/NotifyRename/RenameTransferContext.cpp
diff --git a/native-src/virtual_drive/Wrappers.cpp b/native-src/virtual_drive/Wrappers.cpp
@@ -317,7 +317,6 @@ napi_value ConnectSyncRootWrapper(napi_env env, napi_callback_info args)
         InputSyncCallbacks callbacks = {};
 
         napi_value notifyDeleteCompletionCallback;
-        napi_value notifyRenameCallback;
         napi_value fetchDataCallback;
         napi_value cancelFetchDataCallback;
 
@@ -334,19 +333,6 @@ napi_value ConnectSyncRootWrapper(napi_env env, napi_callback_info args)
             return nullptr;
         }
 
-        if (napi_get_named_property(env, argv[1], "notifyRenameCallback", &notifyRenameCallback) == napi_ok)
-        {
-            napi_create_reference(env, notifyRenameCallback, 1, &callbacks.notify_rename_callback_ref);
-        }
-
-        napi_valuetype valuetype_rename;
-        napi_status type_status_rename = napi_typeof(env, notifyRenameCallback, &valuetype_rename);
-        if (type_status_rename != napi_ok || valuetype_rename != napi_function)
-        {
-            napi_throw_error(env, nullptr, "notifyRenameCallback should be a function.");
-            return nullptr;
-        }
-
         if (napi_get_named_property(env, argv[1], "fetchDataCallback", &fetchDataCallback) == napi_ok)
         {
             napi_create_reference(env, fetchDataCallback, 1, &callbacks.fetch_data_callback_ref);
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@internxt/node-win",
-  "version": "1.0.18",
+  "version": "1.0.19",
   "description": "Drive desktop node addon",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ enum class FileOperationError`
`17`	`17`	`{`
`18`	`18`	`UPLOAD_ERROR,`
`19`	`19`	`DOWNLOAD_ERROR,`
`20`		`- RENAME_ERROR,`
`21`	`20`	`DELETE_ERROR,`
`22`	`21`	`METADATA_READ_ERROR`
`23`	`22`	`};`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`	`void register_threadsafe_callbacks(napi_env env, InputSyncCallbacks input)`
`5`	`5`	`{`
`6`	`6`	`register_threadsafe_notify_delete_callback("NotifyDeleteThreadSafe", env, input);`
`7`		`- register_threadsafe_notify_rename_callback("NotifyRenameThreadSafe", env, input);`
`8`	`7`	`register_threadsafe_fetch_data_callback("FetchDataThreadSafe", env, input);`
`9`	`8`	`register_threadsafe_cancel_fetch_data_callback("CancelFetchDataThreadSafe", env, input);`
`10`	`9`	`}`