Commit

Author: dajimenezriv-internxt

dist/addon.node

@@ -8,7 +8,7 @@ class Placeholders
 public:
     static void MaintainIdentity(std::wstring &fullPath, PCWSTR fileIdentity, bool isDirectory);
     static void ForceShellRefresh(const std::wstring &path);
-    static void UpdateSyncStatus(const std::wstring &filePath, bool syncState, bool isDirectory);
+    static void UpdateSyncStatus(const std::wstring &filePath, bool isDirectory);
     static HRESULT UpdatePinState(const std::wstring &path, const PinState state);
     static std::string GetFileIdentity(const std::wstring &filePath);
     static void UpdateFileIdentity(const std::wstring &filePath, const std::wstring &fileIdentity, bool isDirectory);

include/placeholders_interface/Placeholders.h

@@ -62,76 +62,33 @@ void Placeholders::MaintainIdentity(std::wstring &fullPath, PCWSTR itemIdentity,
     }
 }
 
-/**
- * @brief Mark a file or directory as synchronized
- * @param filePath path to the file or directory
- * @param isDirectory true if the path is a directory, false if it is a file
- * @return void
- */
-void Placeholders::UpdateSyncStatus(const std::wstring &filePath,
-                                    bool inputSyncState,
-                                    bool isDirectory /* = false */)
+void Placeholders::UpdateSyncStatus(const std::wstring &path, bool isDirectory)
 {
-    wprintf(L"[UpdateSyncStatus] Path: %ls\n", filePath.c_str());
-
     DWORD flags = FILE_FLAG_OPEN_REPARSE_POINT;
     if (isDirectory)
         flags |= FILE_FLAG_BACKUP_SEMANTICS;
 
-    HANDLE h = CreateFileW(filePath.c_str(),
-                           FILE_WRITE_ATTRIBUTES,
-                           FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE,
-                           nullptr,
-                           OPEN_EXISTING,
-                           flags,
-                           nullptr);
-
-    if (h == INVALID_HANDLE_VALUE)
-    {
-        wprintf(L"[UpdateSyncStatus] CreateFileW falló: %lu\n", GetLastError());
-        CloseHandle(h);
-        return;
-    }
-
-    CF_IN_SYNC_STATE sync = inputSyncState ? CF_IN_SYNC_STATE_IN_SYNC
-                                           : CF_IN_SYNC_STATE_NOT_IN_SYNC;
-
-    HRESULT hr = CfSetInSyncState(h, sync, CF_SET_IN_SYNC_FLAG_NONE, nullptr);
+    winrt::file_handle fileHandle{CreateFileW(
+        path.c_str(),
+        FILE_WRITE_ATTRIBUTES,
+        FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE,
+        nullptr,
+        OPEN_EXISTING,
+        flags,
+        nullptr)};
 
-    if (FAILED(hr))
-    {
-        switch (HRESULT_CODE(hr))
-        {
-        case ERROR_RETRY:
-            Sleep(50);
-            hr = CfSetInSyncState(h, sync, CF_SET_IN_SYNC_FLAG_NONE, nullptr);
-            wprintf(L"[UpdateSyncStatus] Retry CfSetInSyncState\n");
-            break;
-
-        case ERROR_CLOUD_FILE_PROVIDER_NOT_RUNNING: // 0x1A94
-            SHChangeNotify(SHCNE_UPDATEITEM, SHCNF_PATH, filePath.c_str(), nullptr);
-            wprintf(L"[UpdateSyncStatus] Retry CfSetInSyncState\n");
-            break;
-
-        case ERROR_CLOUD_FILE_NOT_IN_SYNC:
-            convert_to_placeholder(filePath, L"temp_identity");
-            hr = CfSetInSyncState(h, sync, CF_SET_IN_SYNC_FLAG_NONE, nullptr);
-            wprintf(L"[UpdateSyncStatus] Retry CfSetInSyncState\n");
-            break;
-
-        default:
-            wprintf(L"[UpdateSyncStatus] CfSetInSyncState 0x%08X\n", hr);
-            break;
-        }
-    }
-    else
+    if (!fileHandle)
     {
-        wprintf(L"[UpdateSyncStatus] Estado actualizado\n");
+        throw std::runtime_error("Failed to open item: " + std::to_string(GetLastError()));
     }
 
-    CloseHandle(h);
+    winrt::check_hresult(CfSetInSyncState(
+        fileHandle.get(),
+        CF_IN_SYNC_STATE_IN_SYNC,
+        CF_SET_IN_SYNC_FLAG_NONE,
+        nullptr));
 
-    SHChangeNotify(SHCNE_UPDATEITEM, SHCNF_PATH, filePath.c_str(), nullptr);
+    SHChangeNotify(SHCNE_UPDATEITEM, SHCNF_PATH, path.c_str(), nullptr);
 }
 
 void Placeholders::UpdateFileIdentity(const std::wstring &filePath, const std::wstring &fileIdentity, bool isDirectory)

native-src/placeholders_interface/Planceholders.cpp

@@ -35,7 +35,7 @@ napi_value create_folder_placeholder_impl(napi_env env, napi_callback_info info)
 
     winrt::check_hresult(CfCreatePlaceholders(parentPath.c_str(), &cloudEntry, 1, CF_CREATE_FLAG_NONE, NULL));
     // Placeholders::UpdatePinState(path, PinState::OnlineOnly);
-    // UpdateSyncStatus(path, true, true);
+    Placeholders::UpdateSyncStatus(path, true);
 
     return nullptr;
 }

native-src/virtual_drive/create_folder_placeholder.cpp

@@ -1,21 +1,12 @@
 #include <windows.h>
 #include "Placeholders.h"
+#include "napi_extract_args.h"
 
-napi_value update_sync_status_wrapper(napi_env env, napi_callback_info info) {
-    size_t argc = 3;
-    napi_value argv[3];
-    napi_get_cb_info(env, info, &argc, argv, nullptr, nullptr);
+napi_value update_sync_status_wrapper(napi_env env, napi_callback_info info)
+{
+    auto [path, isDirectory] = napi_extract_args<std::wstring, bool>(env, info);
 
-    size_t pathLength;
-    napi_get_value_string_utf16(env, argv[0], nullptr, 0, &pathLength);
-    std::unique_ptr<wchar_t[]> widePath(new wchar_t[pathLength + 1]);
-    napi_get_value_string_utf16(env, argv[0], reinterpret_cast<char16_t *>(widePath.get()), pathLength + 1, nullptr);
-
-    bool inputSyncState, isDirectory;
-    napi_get_value_bool(env, argv[1], &inputSyncState);
-    napi_get_value_bool(env, argv[2], &isDirectory);
-
-    Placeholders::UpdateSyncStatus(widePath.get(), inputSyncState, isDirectory);
+    Placeholders::UpdateSyncStatus(path, isDirectory);
 
     return nullptr;
 }