fix: return user friend error if room name is invalid (#40)

Author: apsantiso

src/modules/call/call.controller.spec.ts

@@ -13,13 +13,14 @@ import { CallUseCase } from './call.usecase';
 import { JoinCallDto, JoinCallResponseDto } from './dto/join-call.dto';
 import { LeaveCallDto } from './dto/leave-call.dto';
 import { createMockUserToken, mockUserPayload } from './fixtures';
+import { v4 } from 'uuid';
 
 describe('Testing Call Endpoints', () => {
   let callController: CallController;
   let callUseCase: DeepMocked<CallUseCase>;
   let roomService: DeepMocked<RoomService>;
 
-  const mockRoomId = 'test-room-id';
+  const mockRoomId = v4();
   const mockJoinCallDto: JoinCallDto = {
     name: 'Test User',
     lastName: 'Smith',
@@ -266,6 +267,14 @@ describe('Testing Call Endpoints', () => {
       });
       expect(result).toEqual(mockJoinCallResponse);
     });
+
+    it('When joining a call with invalid room name (not UUID), then it should throw', async () => {
+      callUseCase.joinCall.mockResolvedValue(mockJoinCallResponse);
+
+      await expect(
+        callController.joinCall('invalid room name', null, mockJoinCallDto),
+      ).rejects.toThrow(BadRequestException);
+    });
   });
 
   describe('Getting users in a call', () => {

src/modules/call/call.controller.ts

@@ -33,6 +33,7 @@ import { CallUseCase } from './call.usecase';
 import { CreateCallResponseDto } from './dto/create-call.dto';
 import { JoinCallDto, JoinCallResponseDto } from './dto/join-call.dto';
 import { LeaveCallDto } from './dto/leave-call.dto';
+import { isUUID } from 'class-validator';
 
 @ApiTags('Call')
 @Controller('call')
@@ -118,6 +119,10 @@ export class CallController {
     @User() user: UserTokenData['payload'],
     @Body() joinCallDto?: JoinCallDto,
   ): Promise<JoinCallResponseDto> {
+    if (!isUUID(roomId)) {
+      throw new BadRequestException('Room id is not valid');
+    }
+
     const { uuid, email } = user || {};
     const isUserAnonymous =
       !user || !!joinCallDto?.anonymousId || joinCallDto?.anonymous === true;