feat(call): allow anonymousId to be created by the frontend

Author: apsantiso

src/modules/call/call.controller.ts

@@ -125,6 +125,7 @@ export class CallController {
       name: joinCallDto?.name,
       lastName: joinCallDto?.lastName,
       anonymous: joinCallDto?.anonymous || !user,
+      anonymousId: joinCallDto?.anonymousId,
       email: email,
     });
   }

src/modules/call/call.usecase.ts

@@ -5,7 +5,7 @@ import {
   Logger,
   NotFoundException,
 } from '@nestjs/common';
-import { v4 as uuidv4 } from 'uuid';
+import { v4 } from 'uuid';
 import { UserTokenData } from '../auth/dto/user.dto';
 import { RoomService } from './services/room.service';
 import { Room } from './domain/room.domain';
@@ -73,6 +73,7 @@ export class CallUseCase {
       name?: string;
       lastName?: string;
       anonymous?: boolean;
+      anonymousId?: string;
       email?: string;
     },
   ): Promise<JoinCallResponseDto> {
@@ -81,16 +82,25 @@ export class CallUseCase {
       throw new NotFoundException(`Specified room not found`);
     }
 
-    const processedUserData = this.processUserData(userData);
-    const isOwner = processedUserData.userId === room.hostId;
+    const joiningUserData = {
+      userId: userData?.anonymous
+        ? (userData?.anonymousId ?? v4())
+        : userData?.userId,
+      name: userData?.name,
+      lastName: userData?.lastName,
+      anonymous: userData?.anonymous || !userData.userId,
+      email: userData?.email,
+    };
+
+    const isOwner = joiningUserData.userId === room.hostId;
 
     if (!isOwner && room.isClosed) {
       throw new ForbiddenException('Room is closed');
     }
 
     const roomUser = await this.roomService.addUserToRoom(
       roomId,
-      processedUserData,
+      joiningUserData,
     );
 
     // Generate token for the user
@@ -99,10 +109,10 @@ export class CallUseCase {
       roomId,
       !!roomUser.anonymous,
       isOwner,
-      processedUserData,
+      joiningUserData,
     );
 
-    if (processedUserData.userId === room.hostId && room.isClosed) {
+    if (joiningUserData.userId === room.hostId && room.isClosed) {
       await this.roomService.openRoom(roomId);
     }
 
@@ -114,39 +124,6 @@ export class CallUseCase {
     };
   }
 
-  private processUserData(userData: {
-    userId?: string;
-    name?: string;
-    lastName?: string;
-    anonymous?: boolean;
-    email?: string;
-  }): {
-    userId: string;
-    name?: string;
-    lastName?: string;
-    anonymous: boolean;
-    email?: string;
-  } {
-    const { userId, name, lastName, anonymous = false, email } = userData;
-
-    if (anonymous || !userId) {
-      return {
-        userId: uuidv4(),
-        name,
-        lastName,
-        anonymous: true,
-      };
-    }
-
-    return {
-      userId,
-      name,
-      lastName,
-      anonymous: false,
-      email,
-    };
-  }
-
   async leaveCall(roomId: string, userId: string): Promise<void> {
     const room = await this.roomService.getRoomByRoomId(roomId);
 

src/modules/call/dto/join-call.dto.ts

@@ -1,5 +1,5 @@
 import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
-import { IsBoolean, IsOptional, IsString } from 'class-validator';
+import { IsBoolean, IsOptional, IsString, IsUUID } from 'class-validator';
 
 export class JoinCallDto {
   @ApiPropertyOptional({
@@ -21,12 +21,21 @@ export class JoinCallDto {
   @ApiPropertyOptional({
     description: 'Whether the user is joining anonymously',
     type: Boolean,
-    default: false,
+    deprecated: true,
   })
   @IsBoolean()
   @IsOptional()
   anonymous?: boolean;
 
+  @ApiPropertyOptional({
+    description: 'Id to use for anonymous user',
+    type: String,
+    required: false,
+  })
+  @IsUUID()
+  @IsOptional()
+  anonymousId?: string;
+
   @IsString()
   @IsOptional()
   email?: string;

src/modules/call/services/room.service.ts

@@ -79,14 +79,9 @@ export class RoomService {
     }
 
     const { userId, name, lastName, anonymous = false } = userData;
-    let userIdToUse = userId;
-
-    if (anonymous || !userIdToUse) {
-      userIdToUse = uuidv4();
-    }
 
     const existingUser = await this.roomUserRepository.findByUserIdAndRoomId(
-      userIdToUse,
+      userId,
       roomId,
     );
 
@@ -96,7 +91,7 @@ export class RoomService {
 
     return this.roomUserRepository.create({
       roomId,
-      userId: userIdToUse,
+      userId,
       name,
       lastName,
       anonymous: Boolean(anonymous),