Merge pull request #83 from internxt/fix/eslint-issues

[_]: fix/eslint-issues

Author: larryrider

eslint.config.mjs

@@ -8,6 +8,7 @@ export default [
   {
     rules: {
       "@typescript-eslint/no-explicit-any": "warn",
+      "no-console": "off"
     }
   }
 ];

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@internxt/inxt-js",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -38,7 +38,7 @@
     "chai": "5.2.0",
     "chai-as-promised": "8.0.1",
     "commander": "14.0.0",
-    "dotenv": "16.6.0",
+    "dotenv": "17.0.1",
     "eslint": "9.29.0",
     "express": "^5.1.0",
     "jest": "30.0.3",

src/api/ExchangeReport.ts

@@ -122,13 +122,11 @@ export class ExchangeReport {
 
   error() {
     this.DownloadError();
-    // eslint-disable-next-line @typescript-eslint/no-empty-function
-    this.sendReport().catch(() => {});
+    this.sendReport().catch(() => { });
   }
 
   success() {
     this.DownloadOk();
-    // eslint-disable-next-line @typescript-eslint/no-empty-function
-    this.sendReport().catch(() => {});
+    this.sendReport().catch(() => { });
   }
 }

src/api/ShardObject.ts

@@ -5,7 +5,6 @@ import { INXTRequest } from '../lib';
 import { ContractMeta } from '../api';
 import { ShardMeta } from '../lib/models';
 import { wrap } from '../lib/utils/error';
-import { logger } from '../lib/utils/logger';
 import { InxtApiI, SendShardToNodeResponse } from '../services/api';
 import { Shard } from './';
 import { get } from '../services/request';

src/cli/CommandInterface.ts

@@ -1,6 +1,7 @@
 import { Command } from 'commander';
 import { EnvironmentConfig } from '../api';
 import { Environment } from '..';
+import { EnvService } from './EnvService';
 
 export interface CommandOpts {
   version: string;
@@ -19,10 +20,10 @@ interface Option {
 
 export function getEnvironment(): Environment {
   const envConfig: EnvironmentConfig = {
-    bridgePass: process.env.BRIDGE_PASS,
-    bridgeUser: process.env.BRIDGE_USER,
-    encryptionKey: process.env.MNEMONIC,
-    bridgeUrl: process.env.BRIDGE_URL,
+    bridgePass: EnvService.instance.get('BRIDGE_PASS'),
+    bridgeUser: EnvService.instance.get('BRIDGE_USER'),
+    encryptionKey: EnvService.instance.get('MNEMONIC'),
+    bridgeUrl: EnvService.instance.get('BRIDGE_URL'),
   };
 
   return new Environment(envConfig);

src/cli/EnvService.ts

@@ -0,0 +1,25 @@
+export interface EnvKeys {
+    readonly BRIDGE_USER: string;
+    readonly BRIDGE_PASS: string;
+    readonly MNEMONIC: string;
+    readonly BUCKET_ID: string;
+    readonly BRIDGE_URL: string;
+    readonly STAGE: string;
+}
+
+
+export class EnvService {
+    public static readonly instance: EnvService = new EnvService();
+
+    /**
+     * Gets the value from an environment key
+     * @param key The environment key to retrieve
+     * @throws {Error} If key is not found in process.env
+     * @returns The value from the environment variable
+     **/
+    public get = (key: keyof EnvKeys): string => {
+        const value = process.env[key];
+        if (!value) throw new Error(`Config key ${key} was not found in process.env`);
+        return value;
+    };
+}

src/cli/download-file.ts

@@ -3,12 +3,13 @@ import { pipeline, Readable } from 'stream';
 
 import { logger } from '../lib/utils/logger';
 import { getEnvironment } from './CommandInterface';
+import { EnvService } from './EnvService';
 
 export async function downloadFile(fileId: string, path: string, concurrency: number) {
   logger.info('Downloading file %s', fileId);
 
   const network = getEnvironment();
-  const bucketId = process.env.BUCKET_ID;
+  const bucketId = EnvService.instance.get('BUCKET_ID');
 
   const destination = createWriteStream(path);
 
@@ -52,7 +53,7 @@ export async function downloadFile(fileId: string, path: string, concurrency: nu
 
     process.exit(0);
   } catch (err) {
-    logger.error('Error downloading file %s', err.message);
+    logger.error('Error downloading file %s', (err as Error).message ?? '');
 
     process.exit(1);
   }

src/cli/get-download-links.ts

@@ -8,6 +8,6 @@ export async function getDownloadLinks(bucketId: string, fileIds: string[]): Pro
     const response = await network.getDownloadLinks(bucketId, fileIds);
     logger.info(`getDownloadLinks response: ${JSON.stringify(response, null, 2)}`);
   } catch (err) {
-    logger.error(`Something went wrong while getting download links ${err.message}`);
+    logger.error(`Something went wrong while getting download links ${(err as Error).message ?? ''}`);
   }
 }

src/cli/get-filo-info.ts

@@ -4,12 +4,13 @@ import { DecryptFileName } from '../lib/utils/crypto';
 import { logger } from '../lib/utils/logger';
 
 import { getEnvironment } from './CommandInterface';
+import { EnvService } from './EnvService';
 
 export function getFileInfo(fileId: string): Promise<void> {
   logger.info('Retrieving info for file %s', fileId);
 
   const network = getEnvironment();
-  const bucketId = process.env.BUCKET_ID;
+  const bucketId = EnvService.instance.get('BUCKET_ID');
 
   if (!network.config.encryptionKey) {
     logger.error('Mnemonic not provided');

src/cli/index.ts

@@ -1,6 +1,6 @@
 import { Command } from 'commander';
 import { config } from 'dotenv';
-config();
+config({ quiet: true });
 
 import * as commands from './Commands';