[PB-5458] feature(versioning): delete versions when file is permanently deleted #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-xt
temporarily deployed
to
development
GitHub Actions
Inactive
|
douglas-xt
changed the title
douglas-xt
force-pushed
the
feature/fv-versions-usage
branch
from
912a006 to
02d0fa7
Compare
Contributor
|
@douglas-xt This might not be required if we already added the background-task to remove all the versions of a file marked as DELETED. fyi @sg-gs |
Member
|
Part of the retention policy seems to be needed @apsantiso. The removal part does not @douglas-xt |
douglas-xt
force-pushed
the
feature/fv-versions-usage
branch
from
1140257 to
c32a61a
Compare
douglas-xt
force-pushed
the
feature/fv-versions-usage
branch
2 times, most recently
from
2d2fb76 to
257dfe9
Compare
Contributor
Author
|
This PR only handles deleting versions when the user permanently deletes files. The retention policy is applied on the file when the user does a replace (in replaceFile), and the proactive cleanup on plan downgrade is implemented in PR #818. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements automatic deletion of file versions when their parent file is permanently deleted.
When a user permanently deletes a file, all its previous versions are also deleted.
When multiple files are removed (e.g., emptying workspace trash), their versions are deleted as well.