Skip to content

[PB-6513, PB-6515] Add argon2 enpoints - #1151

Open
TamaraFinogina wants to merge 13 commits into
masterfrom
add_argon2_endpoints
Open

[PB-6513, PB-6515] Add argon2 enpoints#1151
TamaraFinogina wants to merge 13 commits into
masterfrom
add_argon2_endpoints

Conversation

@TamaraFinogina

@TamaraFinogina TamaraFinogina commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Argon2 endpoints: login & password change. No keys in DTOs, no hash & salt encryption

SDK PR: internxt/sdk#439

@TamaraFinogina TamaraFinogina self-assigned this Aug 31, 2026
@TamaraFinogina

TamaraFinogina commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@jzunigax2 It's all yours :) Definitely missing tests + fixing duplicates. The logic should be similar to what we have currently but simplified - no hash & salt decryption and no key checks.

P.S. I was not sure about DTO names and locations, so it's -v2 and near the existing ones.

@TamaraFinogina
TamaraFinogina marked this pull request as ready for review August 31, 2026 16:56
@sonarqubecloud

sonarqubecloud Bot commented Aug 31, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
36.3% Coverage on New Code (required ≥ 80%)
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apsantiso apsantiso Awaiting requested review from apsantiso apsantiso is a code owner
@jzunigax2 jzunigax2 Awaiting requested review from jzunigax2 jzunigax2 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@TamaraFinogina TamaraFinogina

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TamaraFinogina