[Decode] [PDVT-SH] AV1 CRC Output Enable

AV1 CRC Output Enable

Author: pengwan1

media_driver/agnostic/Xe_M/Xe_HPM/hw/vdbox/mhw_vdbox_avp_hwcmd_xe_hpm.h

@@ -36,10 +36,6 @@
 
 #include "mhw_hwcmd.h"
 
-#ifdef _MEDIA_RESERVED
-#include "mhw_vdbox_avp_cmdpar_ext.h"
-#endif
-
 #pragma once
 #pragma pack(1)
 

media_softlet/agnostic/common/codec/hal/dec/av1/packet/decode_av1_debug_packet.cpp

@@ -0,0 +1,97 @@
+/*
+* Copyright (c) 2025, Intel Corporation
+*
+* Permission is hereby granted, free of charge, to any person obtaining a
+* copy of this software and associated documentation files (the "Software"),
+* to deal in the Software without restriction, including without limitation
+* the rights to use, copy, modify, merge, publish, distribute, sublicense,
+* and/or sell copies of the Software, and to permit persons to whom the
+* Software is furnished to do so, subject to the following conditions:
+*
+* The above copyright notice and this permission notice shall be included
+* in all copies or substantial portions of the Software.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+* OTHER DEALINGS IN THE SOFTWARE.
+*/
+
+//!
+//! \file     decode_av1_debug_packet.cpp
+//! \brief    Defines the implementation for AV1 decode debug sub packet
+//! \details  The AV1 decode debug sub packet implementation provides debug functionality
+//!           for AV1 decode operations, including AVP debug data collection and CRC verification.
+//!
+
+#if (_DEBUG || _RELEASE_INTERNAL)
+
+#include "decode_av1_debug_packet.h"
+#include "decode_utils.h"
+
+namespace decode
+{
+
+Av1DecodeDebugPkt::Av1DecodeDebugPkt(DecodePipeline *pipeline, CodechalHwInterfaceNext *hwInterface)
+    : DecodeSubPacket(pipeline, hwInterface)
+{
+    m_hwInterface = hwInterface;
+    m_pipeline = pipeline;
+}
+
+MOS_STATUS Av1DecodeDebugPkt::Init()
+{
+    DECODE_FUNC_CALL();
+
+    DECODE_CHK_NULL(m_pipeline);
+    DECODE_CHK_NULL(m_hwInterface);
+
+    m_miItf = m_hwInterface->GetMiInterfaceNext();
+    DECODE_CHK_NULL(m_miItf);
+
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS Av1DecodeDebugPkt::Prepare()
+{
+    DECODE_FUNC_CALL();
+
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS Av1DecodeDebugPkt::CalculateCommandSize(uint32_t &commandBufferSize, uint32_t &requestedPatchListSize)
+{
+    DECODE_FUNC_CALL();
+
+    commandBufferSize = 0;
+    requestedPatchListSize = 0;
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS Av1DecodeDebugPkt::Destroy()
+{
+    DECODE_FUNC_CALL();
+
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS Av1DecodeDebugPkt::Execute(MOS_COMMAND_BUFFER& cmdBuffer)
+{
+    DECODE_FUNC_CALL();
+
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS Av1DecodeDebugPkt::Completed()
+{
+    DECODE_FUNC_CALL();
+
+    return MOS_STATUS_SUCCESS;
+}
+
+}  // namespace decode
+
+#endif  // _DEBUG || _RELEASE_INTERNAL

media_softlet/agnostic/common/codec/hal/dec/av1/packet/decode_av1_debug_packet.h

@@ -0,0 +1,116 @@
+/*
+* Copyright (c) 2025, Intel Corporation
+*
+* Permission is hereby granted, free of charge, to any person obtaining a
+* copy of this software and associated documentation files (the "Software"),
+* to deal in the Software without restriction, including without limitation
+* the rights to use, copy, modify, merge, publish, distribute, sublicense,
+* and/or sell copies of the Software, and to permit persons to whom the
+* Software is furnished to do so, subject to the following conditions:
+*
+* The above copyright notice and this permission notice shall be included
+* in all copies or substantial portions of the Software.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+* OTHER DEALINGS IN THE SOFTWARE.
+*/
+
+//!
+//! \file     decode_av1_debug_packet.h
+//! \brief    Defines the common interface for AV1 decode debug sub packet
+//! \details  The AV1 decode debug sub packet interface provides debug functionality
+//!           for AV1 decode operations, including AVP debug data collection and CRC verification.
+//!
+
+#ifndef __DECODE_AV1_DEBUG_PACKET_H__
+#define __DECODE_AV1_DEBUG_PACKET_H__
+
+#if (_DEBUG || _RELEASE_INTERNAL)
+
+#include "decode_sub_packet.h"
+#include "codechal_setting.h"
+#include "decode_pipeline.h"
+
+namespace decode
+{
+
+class Av1DecodeDebugPkt : public DecodeSubPacket
+{
+public:
+    //!
+    //! \brief  AV1 decode debug sub packet constructor
+    //!
+    Av1DecodeDebugPkt(DecodePipeline *pipeline, CodechalHwInterfaceNext *hwInterface);
+
+    //!
+    //! \brief  AV1 decode debug sub packet destructor
+    //!
+    virtual ~Av1DecodeDebugPkt() {};
+
+    //!
+    //! \brief  Initialize the debug sub packet
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Init() override;
+
+    //!
+    //! \brief  Prepare the parameters for debug sub packet
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Prepare() override;
+
+    //!
+    //! \brief  Calculate Command Size
+    //!
+    //! \param  [in, out] commandBufferSize
+    //!         requested size
+    //! \param  [in, out] requestedPatchListSize
+    //!         requested size
+    //! \return MOS_STATUS
+    //!         status
+    //!
+    virtual MOS_STATUS CalculateCommandSize(
+        uint32_t &commandBufferSize,
+        uint32_t &requestedPatchListSize) override;
+
+    //!
+    //! \brief  Destroy the debug sub packet
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Destroy();
+
+    //!
+    //! \brief  Execute debug sub packet
+    //! \param  [in] cmdBuffer
+    //!         Command buffer
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Execute(MOS_COMMAND_BUFFER& cmdBuffer);
+
+    //!
+    //! \brief  Complete debug operations after decode
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Completed();
+
+protected:
+    std::shared_ptr<mhw::mi::Itf> m_miItf = nullptr;
+
+MEDIA_CLASS_DEFINE_END(decode__Av1DecodeDebugPkt)
+};
+
+}
+
+#endif  // _DEBUG || _RELEASE_INTERNAL
+
+#endif  // !__DECODE_AV1_DEBUG_PACKET_H__

media_softlet/agnostic/common/codec/hal/dec/av1/packet/decode_av1_packet.cpp

@@ -27,6 +27,9 @@
 #include "decode_status_report_defs.h"
 #include "decode_predication_packet.h"
 #include "decode_marker_packet.h"
+#if (_DEBUG || _RELEASE_INTERNAL)
+#include "decode_av1_debug_packet.h"
+#endif
 
 namespace decode {
 
@@ -64,6 +67,20 @@ MOS_STATUS Av1DecodePkt::Init()
         m_pictureStatesSize, 1, CODEC_NUM_AV1_SECOND_BB, true, lockableVideoMem);
     DECODE_CHK_NULL(m_secondLevelBBArray);
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+    // Initialize debug packet
+    DecodeSubPacket* debugSubPacket = m_av1Pipeline->GetSubPacket(DecodePacketId(m_av1Pipeline, av1DebugSubPacketId));
+    if (debugSubPacket != nullptr)
+    {
+        Av1DecodeDebugPkt* debugPkt = dynamic_cast<Av1DecodeDebugPkt*>(debugSubPacket);
+        if (debugPkt != nullptr)
+        {
+            m_av1DebugPkt = debugPkt;
+            DECODE_CHK_STATUS(m_av1DebugPkt->Init());
+        }
+    }
+#endif
+
     return MOS_STATUS_SUCCESS;
 }
 
@@ -85,6 +102,14 @@ MOS_STATUS Av1DecodePkt::Destroy()
         DECODE_CHK_STATUS(m_allocator->Destroy(m_secondLevelBBArray));
     }
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+    // Destroy debug packet
+    if (m_av1DebugPkt != nullptr)
+    {
+        DECODE_CHK_STATUS(m_av1DebugPkt->Destroy());
+    }
+#endif
+
     return MOS_STATUS_SUCCESS;
 }
 
@@ -187,6 +212,14 @@ MOS_STATUS Av1DecodePkt::Completed(void *mfxStatus, void *rcsStatus, void *statu
     DecodeStatusReportData *statusReportData = (DecodeStatusReportData *)statusReport;
     DECODE_VERBOSEMESSAGE("Current Frame Index = %d", statusReportData->currDecodedPic.FrameIdx);
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+    // Complete debug packet operations
+    if (m_av1DebugPkt != nullptr)
+    {
+        DECODE_CHK_STATUS(m_av1DebugPkt->Completed());
+    }
+#endif
+
     return MOS_STATUS_SUCCESS;
 }
 
@@ -284,6 +317,14 @@ MOS_STATUS Av1DecodePkt::EndStatusReport(uint32_t srType, MOS_COMMAND_BUFFER* cm
     // Add Mi flush here to ensure end status tag flushed to memory earlier than completed count
     DECODE_CHK_STATUS(MiFlush(*cmdBuffer));
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+    // Execute debug packet
+    if (m_av1DebugPkt != nullptr)
+    {
+        DECODE_CHK_STATUS(m_av1DebugPkt->Execute(*cmdBuffer));
+    }
+#endif
+
     return MOS_STATUS_SUCCESS;
 }
 

media_softlet/agnostic/common/codec/hal/dec/av1/packet/decode_av1_packet.h

@@ -38,6 +38,8 @@
 namespace decode
 {
 
+class Av1DecodeDebugPkt;
+
 class Av1DecodePkt : public CmdPacket, public MediaStatusReportObserver
 {
 public:
@@ -173,6 +175,9 @@ class Av1DecodePkt : public CmdPacket, public MediaStatusReportObserver
     PMHW_BATCH_BUFFER     m_batchBuf = nullptr;
     std::shared_ptr<mhw::vdbox::vdenc::Itf> m_vdencItf = nullptr;
 
+private:
+    Av1DecodeDebugPkt    *m_av1DebugPkt = nullptr;  //!< AV1 debug packet for debug functionality
+
 MEDIA_CLASS_DEFINE_END(decode__Av1DecodePkt)
 };
 

media_softlet/agnostic/common/codec/hal/dec/av1/packet/decode_av1_tile_packet.cpp

@@ -253,6 +253,15 @@ namespace decode
 
         m_av1BasicFeature->m_frameCompletedFlag = par.lastTileOfFrame;
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+        bool crcOutputEnable = false;
+        if (m_av1Pipeline != nullptr)
+        {
+            crcOutputEnable = m_av1Pipeline->GetCRCOutputEnable();
+        }
+        par.enableAvpDebugMode = crcOutputEnable;
+#endif
+
         DECODE_CHK_STATUS(m_avpItf->MHW_ADDCMD_F(AVP_TILE_CODING)(&cmdBuffer));
 
         return MOS_STATUS_SUCCESS;

media_softlet/agnostic/common/codec/hal/dec/av1/packet/media_srcs.cmake

@@ -24,13 +24,15 @@ set(SOFTLET_DECODE_AV1_SOURCES_
     ${CMAKE_CURRENT_LIST_DIR}/decode_av1_picture_packet.cpp
     ${CMAKE_CURRENT_LIST_DIR}/decode_av1_tile_packet.cpp
     ${CMAKE_CURRENT_LIST_DIR}/decode_av1_packet.cpp
+    ${CMAKE_CURRENT_LIST_DIR}/decode_av1_debug_packet.cpp
 )
 
 set(SOFTLET_DECODE_AV1_HEADERS_
     ${SOFTLET_DECODE_AV1_HEADERS_}
     ${CMAKE_CURRENT_LIST_DIR}/decode_av1_picture_packet.h
     ${CMAKE_CURRENT_LIST_DIR}/decode_av1_tile_packet.h
     ${CMAKE_CURRENT_LIST_DIR}/decode_av1_packet.h
+    ${CMAKE_CURRENT_LIST_DIR}/decode_av1_debug_packet.h
 )
 
 source_group( CodecHalNext\\Shared\\Decode FILES ${SOFTLET_DECODE_AV1_SOURCES_} ${SOFTLET_DECODE_AV1_HEADERS_} )

media_softlet/agnostic/common/codec/hal/dec/av1/pipeline/decode_av1_pipeline.cpp

@@ -29,6 +29,9 @@
 #include "decode_av1_feature_manager.h"
 #include "decode_huc_packet_creator_base.h"
 #include "media_debug_fast_dump.h"
+#if (_DEBUG || _RELEASE_INTERNAL)
+#include "decode_av1_debug_packet.h"
+#endif
 
 namespace decode {
 
@@ -154,6 +157,19 @@ MOS_STATUS Av1Pipeline::CreateSubPackets(DecodeSubPacketManager &subPacketManage
 
     DECODE_CHK_STATUS(DecodePipeline::CreateSubPackets(subPacketManager, codecSettings));
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+    // Create debug packet
+    Av1DecodeDebugPkt *debugPkt = MOS_New(Av1DecodeDebugPkt, this, m_hwInterface);
+    DECODE_CHK_NULL(debugPkt);
+    MOS_STATUS status = subPacketManager.Register(
+                        DecodePacketId(this, av1DebugSubPacketId), *debugPkt);
+    if (status != MOS_STATUS_SUCCESS)
+    {
+        MOS_Delete(debugPkt);
+        return status;
+    }
+#endif
+
     return MOS_STATUS_SUCCESS;
 }
 

media_softlet/agnostic/common/codec/hal/dec/av1/pipeline/decode_av1_pipeline.h

@@ -63,6 +63,7 @@ class Av1Pipeline : public DecodePipeline
     DeclareDecodePacketId(av1PictureSubPacketId);
     DeclareDecodePacketId(av1TileSubPacketId);
     DeclareDecodePacketId(av1DecodeAqmId);
+    DeclareDecodePacketId(av1DebugSubPacketId);
 
 protected:
     //!