[Decode] [PDVT-SH] AVC CRC Output Enable

AVC CRC Output Enable

Author: pengwan1

media_softlet/agnostic/common/codec/hal/dec/avc/packet/decode_avc_debug_packet.cpp

@@ -0,0 +1,96 @@
+/*
+* Copyright (c) 2025, Intel Corporation
+*
+* Permission is hereby granted, free of charge, to any person obtaining a
+* copy of this software and associated documentation files (the "Software"),
+* to deal in the Software without restriction, including without limitation
+* the rights to use, copy, modify, merge, publish, distribute, sublicense,
+* and/or sell copies of the Software, and to permit persons to whom the
+* Software is furnished to do so, subject to the following conditions:
+*
+* The above copyright notice and this permission notice shall be included
+* in all copies or substantial portions of the Software.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+* OTHER DEALINGS IN THE SOFTWARE.
+*/
+
+//!
+//! \file     decode_avc_debug_packet.cpp
+//! \brief    Defines the implementation of AVC decode debug packet
+//! \details  The AVC decode debug packet provides debug functionality for AVC decoding
+//!
+
+#if (_DEBUG || _RELEASE_INTERNAL)
+
+#include "decode_avc_debug_packet.h"
+#include "decode_utils.h"
+
+namespace decode
+{
+
+AvcDecodeDebugPkt::AvcDecodeDebugPkt(DecodePipeline *pipeline, CodechalHwInterfaceNext *hwInterface)
+    : DecodeSubPacket(pipeline, hwInterface)
+{
+    m_hwInterface = hwInterface;
+    m_pipeline = pipeline;
+}
+
+MOS_STATUS AvcDecodeDebugPkt::Init()
+{
+    DECODE_FUNC_CALL();
+
+    DECODE_CHK_NULL(m_pipeline);
+    DECODE_CHK_NULL(m_hwInterface);
+
+    m_miItf = m_hwInterface->GetMiInterfaceNext();
+    DECODE_CHK_NULL(m_miItf);
+
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS AvcDecodeDebugPkt::Prepare()
+{
+    DECODE_FUNC_CALL();
+
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS AvcDecodeDebugPkt::CalculateCommandSize(uint32_t &commandBufferSize, uint32_t &requestedPatchListSize)
+{
+    DECODE_FUNC_CALL();
+
+    commandBufferSize = 0;
+    requestedPatchListSize = 0;
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS AvcDecodeDebugPkt::Destroy()
+{
+    DECODE_FUNC_CALL();
+
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS AvcDecodeDebugPkt::Execute(MOS_COMMAND_BUFFER& cmdBuffer, MediaStatusReport *statusReport)
+{
+    DECODE_FUNC_CALL();
+
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS AvcDecodeDebugPkt::Completed()
+{
+    DECODE_FUNC_CALL();
+
+    return MOS_STATUS_SUCCESS;
+}
+
+}  // namespace decode
+
+#endif  // (_DEBUG || _RELEASE_INTERNAL)

media_softlet/agnostic/common/codec/hal/dec/avc/packet/decode_avc_debug_packet.h

@@ -0,0 +1,114 @@
+/*
+* Copyright (c) 2025, Intel Corporation
+*
+* Permission is hereby granted, free of charge, to any person obtaining a
+* copy of this software and associated documentation files (the "Software"),
+* to deal in the Software without restriction, including without limitation
+* the rights to use, copy, modify, merge, publish, distribute, sublicense,
+* and/or sell copies of the Software, and to permit persons to whom the
+* Software is furnished to do so, subject to the following conditions:
+*
+* The above copyright notice and this permission notice shall be included
+* in all copies or substantial portions of the Software.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+* OTHER DEALINGS IN THE SOFTWARE.
+*/
+
+//!
+//! \file     decode_avc_debug_packet.h
+//! \brief    Defines the implementation of AVC decode debug packet
+//! \details  The AVC decode debug packet provides debug functionality for AVC decoding
+//!
+
+#ifndef __DECODE_AVC_DEBUG_PACKET_H__
+#define __DECODE_AVC_DEBUG_PACKET_H__
+
+#if (_DEBUG || _RELEASE_INTERNAL)
+
+#include "decode_sub_packet.h"
+#include "media_cmd_packet.h"
+
+namespace decode
+{
+
+class AvcDecodeDebugPkt : public DecodeSubPacket
+{
+public:
+    //!
+    //! \brief  AVC decode debug sub packet constructor
+    //!
+    AvcDecodeDebugPkt(DecodePipeline *pipeline, CodechalHwInterfaceNext *hwInterface);
+
+    //!
+    //! \brief  AVC decode debug sub packet destructor
+    //!
+    virtual ~AvcDecodeDebugPkt() {};
+
+    //!
+    //! \brief  Initialize the debug sub packet
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Init() override;
+
+    //!
+    //! \brief  Prepare the parameters for debug sub packet
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Prepare() override;
+
+    //!
+    //! \brief  Calculate Command Size
+    //!
+    //! \param  [in, out] commandBufferSize
+    //!         requested size
+    //! \param  [in, out] requestedPatchListSize
+    //!         requested size
+    //! \return MOS_STATUS
+    //!         status
+    //!
+    virtual MOS_STATUS CalculateCommandSize(
+        uint32_t &commandBufferSize,
+        uint32_t &requestedPatchListSize) override;
+
+    //!
+    //! \brief  Destroy the debug sub packet
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Destroy();
+
+    //!
+    //! \brief  Execute debug sub packet
+    //! \param  [in] cmdBuffer
+    //!         Command buffer
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Execute(MOS_COMMAND_BUFFER& cmdBuffer, MediaStatusReport *statusReport);
+
+    //!
+    //! \brief  Complete debug operations after decode
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS Completed();
+
+protected:
+    std::shared_ptr<mhw::mi::Itf> m_miItf = nullptr;
+
+MEDIA_CLASS_DEFINE_END(decode__AvcDecodeDebugPkt)
+};
+
+}  // namespace decode
+
+#endif  // (_DEBUG || _RELEASE_INTERNAL)
+
+#endif  // !__DECODE_AVC_DEBUG_PACKET_H__

media_softlet/agnostic/common/codec/hal/dec/avc/packet/decode_avc_packet.cpp

@@ -30,6 +30,9 @@
 #include "decode_status_report_defs.h"
 #include "decode_predication_packet.h"
 #include "codechal_debug.h"
+#if (_DEBUG || _RELEASE_INTERNAL)
+#include "decode_avc_debug_packet.h"
+#endif
 
 namespace decode
 {
@@ -63,6 +66,17 @@ MOS_STATUS AvcDecodePkt::Init()
     DECODE_CHK_NULL(m_slicePkt);
     DECODE_CHK_STATUS(m_slicePkt->CalculateCommandSize(m_sliceStatesSize, m_slicePatchListSize));
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+    // Initialize debug packet
+    DecodeSubPacket* debugSubPacket = m_avcPipeline->GetSubPacket(
+        DecodePacketId(m_avcPipeline, avcDebugSubPacketId));
+    m_debugPkt = dynamic_cast<AvcDecodeDebugPkt*>(debugSubPacket);
+    if (m_debugPkt != nullptr)
+    {
+        DECODE_CHK_STATUS(m_debugPkt->Init());
+    }
+#endif
+
     return MOS_STATUS_SUCCESS;
 }
 
@@ -79,6 +93,15 @@ MOS_STATUS AvcDecodePkt::Prepare()
 MOS_STATUS AvcDecodePkt::Destroy()
 {
     m_statusReport->UnregistObserver(this);
+
+#if (_DEBUG || _RELEASE_INTERNAL)
+    // Destroy debug packet
+    if (m_debugPkt != nullptr)
+    {
+        DECODE_CHK_STATUS(m_debugPkt->Destroy());
+    }
+#endif
+
     return MOS_STATUS_SUCCESS;
 }
 
@@ -180,6 +203,14 @@ MOS_STATUS AvcDecodePkt::Completed(void *mfxStatus, void *rcsStatus, void *statu
     DECODE_VERBOSEMESSAGE("Current Frame Index = %d", statusReportData->currDecodedPic.FrameIdx);
     DECODE_VERBOSEMESSAGE("FrameCrc = 0x%x", statusReportData->frameCrc);
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+    // Call debug packet completion handling for MFX debug functionality
+    if (m_debugPkt != nullptr)
+    {
+        DECODE_CHK_STATUS(m_debugPkt->Completed());
+    }
+#endif
+
     return MOS_STATUS_SUCCESS;
 }
 
@@ -280,6 +311,13 @@ MOS_STATUS AvcDecodePkt::EndStatusReport(uint32_t srType, MOS_COMMAND_BUFFER *cm
     DECODE_FUNC_CALL();
     DECODE_CHK_NULL(cmdBuffer);
     DECODE_CHK_STATUS(ReadMfxStatus(m_statusReport, *cmdBuffer));
+#if (_DEBUG || _RELEASE_INTERNAL)
+        // Execute debug packet for MFX debug functionality before MiFlush
+        if (m_debugPkt != nullptr)
+        {
+            DECODE_CHK_STATUS(m_debugPkt->Execute(*cmdBuffer, m_statusReport));
+        }
+#endif
     DECODE_CHK_STATUS(MediaPacket::EndStatusReportNext(srType, cmdBuffer));
 
     MediaPerfProfiler *perfProfiler = MediaPerfProfiler::Instance();
@@ -334,4 +372,4 @@ MOS_STATUS AvcDecodePkt::SetCencBatchBuffer(
     return MOS_STATUS_SUCCESS;
 }
 
-}  // namespace decode
+}  // namespace decode

media_softlet/agnostic/common/codec/hal/dec/avc/packet/decode_avc_packet.h

@@ -36,8 +36,15 @@
 #include "decode_avc_picture_packet.h"
 #include "decode_avc_slice_packet.h"
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+#include "decode_avc_debug_packet.h"
+#endif
+
 namespace decode
 {
+
+class AvcDecodeDebugPkt;
+
 class AvcDecodePkt : public CmdPacket, public MediaStatusReportObserver
 {
 public:
@@ -166,6 +173,10 @@ class AvcDecodePkt : public CmdPacket, public MediaStatusReportObserver
     uint32_t m_sliceStatesSize      = 0;
     uint32_t m_slicePatchListSize   = 0;
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+    AvcDecodeDebugPkt *m_debugPkt = nullptr;
+#endif
+
 MEDIA_CLASS_DEFINE_END(decode__AvcDecodePkt)
 };
 }  // namespace decode

media_softlet/agnostic/common/codec/hal/dec/avc/packet/media_srcs.cmake

@@ -1,4 +1,4 @@
-# Copyright (c) 2021-2022, Intel Corporation
+# Copyright (c) 2021-2025, Intel Corporation
 #
 # Permission is hereby granted, free of charge, to any person obtaining a
 # copy of this software and associated documentation files (the "Software"),
@@ -25,6 +25,7 @@ set(SOFTLET_DECODE_AVC_SOURCES_
     ${CMAKE_CURRENT_LIST_DIR}/decode_avc_picture_packet.cpp
     ${CMAKE_CURRENT_LIST_DIR}/decode_avc_packet.cpp
     ${CMAKE_CURRENT_LIST_DIR}/decode_avc_downsampling_packet.cpp
+    ${CMAKE_CURRENT_LIST_DIR}/decode_avc_debug_packet.cpp
 )
 
 set(SOFTLET_DECODE_AVC_HEADERS_
@@ -33,6 +34,7 @@ set(SOFTLET_DECODE_AVC_HEADERS_
     ${CMAKE_CURRENT_LIST_DIR}/decode_avc_slice_packet.h
     ${CMAKE_CURRENT_LIST_DIR}/decode_avc_picture_packet.h
     ${CMAKE_CURRENT_LIST_DIR}/decode_avc_downsampling_packet.h
+    ${CMAKE_CURRENT_LIST_DIR}/decode_avc_debug_packet.h
 )
 
 source_group( CodecHalNext\\Shared\\Decode FILES ${SOFTLET_DECODE_AVC_SOURCES_} ${SOFTLET_DECODE_AVC_HEADERS_} )

media_softlet/agnostic/common/codec/hal/dec/avc/pipeline/decode_avc_pipeline.cpp

@@ -235,6 +235,19 @@ namespace decode
 
         DECODE_CHK_STATUS(DecodePipeline::CreateSubPackets(subPacketManager, codecSettings));
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+        // Create debug packet
+        AvcDecodeDebugPkt *debugPkt = MOS_New(AvcDecodeDebugPkt, this, m_hwInterface);
+        DECODE_CHK_NULL(debugPkt);
+        MOS_STATUS status = subPacketManager.Register(
+                            DecodePacketId(this, avcDebugSubPacketId), *debugPkt);
+        if (status != MOS_STATUS_SUCCESS)
+        {
+            MOS_Delete(debugPkt);
+            return status;
+        }
+#endif
+
         return MOS_STATUS_SUCCESS;
     }
 

media_softlet/agnostic/common/codec/hal/dec/avc/pipeline/decode_avc_pipeline.h

@@ -29,6 +29,10 @@
 #include "decode_pipeline.h"
 #include "decode_avc_basic_feature.h"
 
+#if (_DEBUG || _RELEASE_INTERNAL)
+#include "decode_avc_debug_packet.h"
+#endif
+
 namespace decode {
 
 class AvcPipeline : public DecodePipeline
@@ -80,6 +84,9 @@ class AvcPipeline : public DecodePipeline
     DeclareDecodePacketId(avcSliceSubPacketId);
     DeclareDecodePacketId(avcFormatMonoPicPktId);
     DeclareDecodePacketId(avcDecodeAqmId);
+#if (_DEBUG || _RELEASE_INTERNAL)
+    DeclareDecodePacketId(avcDebugSubPacketId);
+#endif
 
 protected:
     //!