Small refactor in SIMDCF Conformance pass

Use IRBuilder for goto and join lowering in SimdCFConformance pass

Author: skachkov-intel

IGC/VectorCompiler/lib/GenXCodeGen/GenXSimdCFConformance.cpp

@@ -395,8 +395,9 @@ class GenXSimdCFConformance {
                      BasicBlock *PhiPredBlock = nullptr);
   Value *lowerPHIUse(PHINode *PN, SetVector<Value *> &ToRemove);
   Value *lowerArgumentUse(Argument *Arg);
-  Value *insertCond(Value *OldVal, Value *NewVal, const Twine &Name, Instruction *InsertBefore, const DebugLoc &DL);
-  Value *truncateCond(Value *In, Type *Ty, const Twine &Name, Instruction *InsertBefore, const DebugLoc &DL);
+  Value *insertCond(Value *OldVal, Value *NewVal, const Twine &Name,
+                    IRBuilder<> &IRB);
+  Value *truncateCond(Value *In, Type *Ty, const Twine &Name, IRBuilder<> &IRB);
   void lowerGoto(CallInst *Goto);
   void lowerJoin(CallInst *Join);
   void replaceGotoJoinUses(CallInst *GotoJoin, ArrayRef<Value *> Vals);
@@ -3484,8 +3485,7 @@ void GenXSimdCFConformance::checkInterference(SetVector<SimpleValue> *Vals,
  * Return:  value, possibly the same as the input value
  */
 Value *GenXSimdCFConformance::insertCond(Value *OldVal, Value *NewVal,
-    const Twine &Name, Instruction *InsertBefore, const DebugLoc &DL)
-{
+                                         const Twine &Name, IRBuilder<> &IRB) {
   unsigned OldWidth =
       cast<IGCLLVM::FixedVectorType>(OldVal->getType())->getNumElements();
   unsigned NewWidth =
@@ -3497,27 +3497,24 @@ Value *GenXSimdCFConformance::insertCond(Value *OldVal, Value *NewVal,
   // GenXLowering decides whether this is suitable to lower to wrpredregion, or
   // needs to be lowered to something less efficient.
   SmallVector<Constant *, 32> Indices;
-  Type *I32Ty = Type::getInt32Ty(InsertBefore->getContext());
   unsigned i;
   for (i = 0; i != NewWidth; ++i)
-    Indices.push_back(ConstantInt::get(I32Ty, i));
-  auto UndefIndex = UndefValue::get(I32Ty);
+    Indices.push_back(IRB.getInt32(i));
+  auto UndefIndex = UndefValue::get(IRB.getInt32Ty());
   for (; i != OldWidth; ++i)
     Indices.push_back(UndefIndex);
-  auto SV1 = new ShuffleVectorInst(NewVal, UndefValue::get(NewVal->getType()),
-      ConstantVector::get(Indices), NewVal->getName() + ".extend", InsertBefore);
-  SV1->setDebugLoc(DL);
+  auto SV = IRB.CreateShuffleVector(NewVal, UndefValue::get(NewVal->getType()),
+                                    ConstantVector::get(Indices),
+                                    NewVal->getName() + ".extend");
   if (isa<UndefValue>(OldVal))
-    return SV1;
+    return SV;
   Indices.clear();
   for (i = 0; i != NewWidth; ++i)
-    Indices.push_back(ConstantInt::get(I32Ty, i + OldWidth));
+    Indices.push_back(IRB.getInt32(i + OldWidth));
   for (; i != OldWidth; ++i)
-    Indices.push_back(ConstantInt::get(I32Ty, i));
-  auto SV2 = new ShuffleVectorInst(OldVal, SV1, ConstantVector::get(Indices),
-      Name, InsertBefore);
-  SV2->setDebugLoc(DL);
-  return SV2;
+    Indices.push_back(IRB.getInt32(i));
+  return IRB.CreateShuffleVector(OldVal, SV, ConstantVector::get(Indices),
+                                 Name);
 }
 
 /***********************************************************************
@@ -3532,23 +3529,19 @@ Value *GenXSimdCFConformance::insertCond(Value *OldVal, Value *NewVal,
  * Return:  value, possibly the same as the input value
  */
 Value *GenXSimdCFConformance::truncateCond(Value *In, Type *Ty,
-    const Twine &Name, Instruction *InsertBefore, const DebugLoc &DL)
-{
+                                           const Twine &Name,
+                                           IRBuilder<> &IRB) {
   unsigned InWidth =
       cast<IGCLLVM::FixedVectorType>(In->getType())->getNumElements();
   unsigned TruncWidth = cast<IGCLLVM::FixedVectorType>(Ty)->getNumElements();
   if (InWidth == TruncWidth)
     return In;
   // Do the truncate with shufflevector. GenXLowering lowers it to rdpredregion.
-  SmallVector<Constant *, 32> Indices;
-  Type *I32Ty = Type::getInt32Ty(InsertBefore->getContext());
-  unsigned i;
-  for (i = 0; i != TruncWidth; ++i)
-    Indices.push_back(ConstantInt::get(I32Ty, i));
-  auto SV = new ShuffleVectorInst(In, UndefValue::get(In->getType()),
-      ConstantVector::get(Indices), Name, InsertBefore);
-  SV->setDebugLoc(DL);
-  return SV;
+  SmallVector<Constant *, 32> Indices(TruncWidth);
+  for (unsigned i = 0; i < TruncWidth; ++i)
+    Indices.push_back(IRB.getInt32(i));
+  return IRB.CreateShuffleVector(In, UndefValue::get(In->getType()),
+                                 ConstantVector::get(Indices), Name);
 }
 
 /***********************************************************************
@@ -3562,44 +3555,33 @@ Value *GenXSimdCFConformance::truncateCond(Value *In, Type *Ty,
 void GenXSimdCFConformance::lowerGoto(CallInst *Goto)
 {
   LLVM_DEBUG(dbgs() << "lowerGoto: " << *Goto << "\n");
-  const DebugLoc &DL = Goto->getDebugLoc();
+  IRBuilder<> IRB(Goto);
   if (EnableGenXGotoJoin && !lowerSimdCF)
     DiagnosticInfoSimdCF::emit(Goto, "failed to optimize SIMD branch", DS_Warning);
   Value *Results[3];
   auto EM = Goto->getOperand(0);
   auto Cond = Goto->getOperand(2);
   // EM is always 32 bit. Extract SubEM, of the same width as Cond, from it.
-  auto OldSubEM = truncateCond(EM, Cond->getType(),
-      EM->getName() + ".sub", Goto, DL);
+  auto OldSubEM =
+      truncateCond(EM, Cond->getType(), EM->getName() + ".sub", IRB);
   // Result 1: NewRM = OldRM | (SubEM & ~Cond)
-  auto NotCond = BinaryOperator::Create(Instruction::Xor, Cond,
-      Constant::getAllOnesValue(Cond->getType()),
-      Goto->getName() + ".notcond", Goto);
-  NotCond->setDebugLoc(DL);
-  auto NotCondAndSubEM = BinaryOperator::Create(Instruction::And, NotCond,
-      OldSubEM, Goto->getName() + ".disabling", Goto);
-  NotCondAndSubEM->setDebugLoc(DL);
+  auto NotCond = IRB.CreateXor(Cond, Constant::getAllOnesValue(Cond->getType()),
+                               Goto->getName() + ".notcond");
+  auto NotCondAndSubEM =
+      IRB.CreateAnd(NotCond, OldSubEM, Goto->getName() + ".disabling");
   Value *OldRM = Goto->getArgOperand(1);
-  auto NewRM = BinaryOperator::Create(Instruction::Or, OldRM, NotCondAndSubEM,
-      Goto->getName() + ".newRM", Goto);
-  NewRM->setDebugLoc(DL);
+  auto NewRM = IRB.CreateOr(OldRM, NotCondAndSubEM, Goto->getName() + ".newRM");
   Results[1] = NewRM;
   // And SubEM with Cond.
-  auto SubEM = BinaryOperator::Create(Instruction::And, OldSubEM, Cond,
-      Goto->getName() + ".subEM", Goto);
-  SubEM->setDebugLoc(DL);
+  auto SubEM = IRB.CreateAnd(OldSubEM, Cond, Goto->getName() + ".subEM");
   // Insert that back into EM. That is result 0.
-  Results[0] = EM = insertCond(EM, SubEM, Goto->getName() + ".EM", Goto, DL);
+  Results[0] = EM = insertCond(EM, SubEM, Goto->getName() + ".EM", IRB);
   // Result 2: BranchCond = !any(SubEM)
   Function *AnyFunc = GenXIntrinsic::getGenXDeclaration(M, GenXIntrinsic::genx_any,
       SubEM->getType());
-  auto Any = CallInst::Create(AnyFunc, SubEM,
-      SubEM->getName() + ".any", Goto);
-  Any->setDebugLoc(DL);
-  auto Not = BinaryOperator::Create(Instruction::Xor, Any,
-      Constant::getAllOnesValue(Any->getType()),
-      Any->getName() + ".not", Goto);
-  Not->setDebugLoc(DL);
+  auto Any = IRB.CreateCall(AnyFunc, SubEM, SubEM->getName() + ".any");
+  auto Not = IRB.CreateXor(Any, Constant::getAllOnesValue(Any->getType()),
+                           Any->getName() + ".not");
   Results[2] = Not;
   // Replace uses.
   replaceGotoJoinUses(Goto, Results);
@@ -3613,29 +3595,22 @@ void GenXSimdCFConformance::lowerGoto(CallInst *Goto)
 void GenXSimdCFConformance::lowerJoin(CallInst *Join)
 {
   LLVM_DEBUG(dbgs() << "lowerJoin: " << *Join << "\n");
-  const DebugLoc &DL = Join->getDebugLoc();
+  IRBuilder<> IRB(Join);
   Value *Results[2];
   auto EM = Join->getOperand(0);
   auto RM = Join->getOperand(1);
   // EM is always 32 bit. Extract SubEM, of the same width as RM, from it.
-  auto OldSubEM = truncateCond(EM, RM->getType(), EM->getName() + ".sub",
-      Join, DL);
+  auto OldSubEM = truncateCond(EM, RM->getType(), EM->getName() + ".sub", IRB);
   // Or it with RM.
-  auto SubEM = BinaryOperator::Create(Instruction::Or, OldSubEM, RM,
-      Join->getName() + ".subEM", Join);
-  SubEM->setDebugLoc(DL);
+  auto SubEM = IRB.CreateOr(OldSubEM, RM, Join->getName() + ".subEM");
   // Insert that back into EM. That is result 0.
-  Results[0] = EM = insertCond(EM, SubEM, Join->getName() + ".EM", Join, DL);
+  Results[0] = EM = insertCond(EM, SubEM, Join->getName() + ".EM", IRB);
   // Result 1: BranchCond = !any(SubEM)
   Function *AnyFunc = GenXIntrinsic::getGenXDeclaration(M, GenXIntrinsic::genx_any,
       SubEM->getType());
-  auto Any = CallInst::Create(AnyFunc, SubEM,
-      SubEM->getName() + ".any", Join);
-  Any->setDebugLoc(DL);
-  auto Not = BinaryOperator::Create(Instruction::Xor, Any,
-      Constant::getAllOnesValue(Any->getType()),
-      Any->getName() + ".not", Join);
-  Not->setDebugLoc(DL);
+  auto Any = IRB.CreateCall(AnyFunc, SubEM, SubEM->getName() + ".any");
+  auto Not = IRB.CreateXor(Any, Constant::getAllOnesValue(Any->getType()),
+                           Any->getName() + ".not");
   Results[1] = Not;
   // Replace uses.
   replaceGotoJoinUses(Join, Results);