Skip to content

Commit f5a18c1

Browse files
youfengwuigcbot
authored andcommitted
[Autobackout][FuncReg]Revert of change: 9db286b
disable-inline-func-w-implicit-args by default to reduce compile-time
1 parent a5ed9c7 commit f5a18c1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

IGC/Compiler/CISACodeGen/EstimateFunctionSize.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ namespace {
152152
/// \brief A single step to expand F: accumulate the size and remove it
153153
/// from the callee list.
154154
void expand(FunctionNode* Node) {
155-
if (IGC_IS_FLAG_ENABLED(ForceInlineImplicitArgFuncs) && HasImplicitArg == false && Node->HasImplicitArg == true)
155+
if( IGC_IS_FLAG_ENABLED(ControlInlineImplicitArgs) && HasImplicitArg == false && Node->HasImplicitArg == true )
156156
{
157157
HasImplicitArg = true;
158158
if( ( IGC_GET_FLAG_VALUE( PrintControlKernelTotalSize ) & 0x40 ) != 0 )
@@ -311,7 +311,7 @@ void EstimateFunctionSize::analyze() {
311311
}
312312
}
313313
// check functions and mark those that use implicit args.
314-
if (IGC_IS_FLAG_ENABLED(ForceInlineImplicitArgFuncs))
314+
if( IGC_IS_FLAG_ENABLED( ControlInlineImplicitArgs ) )
315315
{
316316
for( auto I = ECG.begin(), E = ECG.end(); I != E; ++I )
317317
{
@@ -469,7 +469,7 @@ bool EstimateFunctionSize::funcIsGoodtoTrim( llvm::Function* F)
469469
return false; /* user specified alwaysInline */
470470
if ( isTrimmedFunction( F ) ) /* already trimmed by other kernels */
471471
return false;
472-
if (IGC_IS_FLAG_ENABLED(ForceInlineImplicitArgFuncs) && func->HasImplicitArg)
472+
if( IGC_IS_FLAG_ENABLED( ControlInlineImplicitArgs ) && func->HasImplicitArg )
473473
{
474474
if( ( IGC_GET_FLAG_VALUE( PrintControlKernelTotalSize ) & 0x20 ) != 0 )
475475
{

IGC/common/igc_flags.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ DECLARE_IGC_REGKEY(bool, EnableThreadCombiningWithNoSLM, false, "Enable thread c
519519
DECLARE_IGC_REGKEY(DWORD, SubroutineThreshold, 110000, "Minimal kernel size to enable subroutines", false)
520520
DECLARE_IGC_REGKEY(DWORD, SubroutineInlinerThreshold, 3000, "Subroutine inliner threshold", false)
521521
DECLARE_IGC_REGKEY(bool, ControlKernelTotalSize, true, "Control kernel total size", true)
522-
DECLARE_IGC_REGKEY(bool, ForceInlineImplicitArgFuncs, false, "Avoid trimming functions with implicit args", true)
522+
DECLARE_IGC_REGKEY(bool, ControlInlineImplicitArgs, true, "Avoid trimming functions with implicit args", true)
523523
DECLARE_IGC_REGKEY(DWORD, ControlInlineTinySize, 200, "Tiny function size for controlling kernel total size", true)
524524
DECLARE_IGC_REGKEY(DWORD, PrintControlKernelTotalSize, 0, "Print Control kernel total size", true)
525525
DECLARE_IGC_REGKEY(bool, AddNoInlineToTrimmedFunctions, false, "Tell late passes not to inline trimmed functions", false)

0 commit comments

Comments
 (0)