Skip to content

Commit f2d3fa8

Browse files
Anton Sidorenkoigcbot
authored andcommitted
replace StringRef _lower methods
Replace StringRef *_lower methods with *_insensitive
1 parent 99b0dfc commit f2d3fa8

File tree

5 files changed

+48
-22
lines changed

5 files changed

+48
-22
lines changed

IGC/VectorCompiler/include/vc/GenXOpts/Utils/KernelInfo.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ SPDX-License-Identifier: MIT
1919

2020
#include <unordered_map>
2121

22+
#include "llvmWrapper/ADT/StringRef.h"
23+
2224
namespace llvm {
2325
namespace genx {
2426

@@ -85,8 +87,8 @@ using ArgToImplicitLinearization =
8587
std::unordered_map<Argument *, LinearizedArgInfo>;
8688

8789
inline bool isDescBufferType(StringRef TypeDesc) {
88-
return (TypeDesc.find_lower("buffer_t") != StringRef::npos &&
89-
TypeDesc.find_lower("image1d_buffer_t") == StringRef::npos);
90+
return (IGCLLVM::contains_insensitive(TypeDesc, "buffer_t") &&
91+
!IGCLLVM::contains_insensitive(TypeDesc, "image1d_buffer_t"));
9092
}
9193

9294
/// KernelMetadata : class to parse and update kernel metadata

IGC/VectorCompiler/lib/GenXCodeGen/GenXThreadPrivateMemory.cpp

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ SPDX-License-Identifier: MIT
2626
#include "vc/Utils/General/BreakConst.h"
2727

2828
#include "Probe/Assertion.h"
29+
#include "llvmWrapper/ADT/StringRef.h"
2930
#include "llvmWrapper/IR/DerivedTypes.h"
3031
#include "llvmWrapper/IR/Function.h"
3132
#include "llvmWrapper/IR/InstrTypes.h"
@@ -1577,15 +1578,17 @@ void GenXThreadPrivateMemory::visitFunction(Function &F) {
15771578
MDNode *ArgDescNode =
15781579
cast<MDNode>(Node->getOperand(KernelMDOp::ArgTypeDescs));
15791580

1580-
for (auto &Arg : F.args())
1581-
if (ArgDescNode->getNumOperands() > Arg.getArgNo() &&
1582-
cast<MDString>(ArgDescNode->getOperand(Arg.getArgNo()))
1583-
->getString()
1584-
.find_lower("svmptr_t") != StringRef::npos) {
1585-
if (!m_useGlobalMem)
1586-
switchStack(*F.getParent());
1587-
LLVM_DEBUG(dbgs() << "Adding svm arg " << Arg << " of " << F.getName()
1588-
<< "\n");
1589-
m_args.insert(&Arg);
1590-
}
1581+
for (auto &Arg : F.args()) {
1582+
if (ArgDescNode->getNumOperands() <= Arg.getArgNo())
1583+
continue;
1584+
StringRef SvmMD =
1585+
cast<MDString>(ArgDescNode->getOperand(Arg.getArgNo()))->getString();
1586+
if (!IGCLLVM::contains_insensitive(SvmMD, "svmptr_t"))
1587+
continue;
1588+
if (!m_useGlobalMem)
1589+
switchStack(*F.getParent());
1590+
LLVM_DEBUG(dbgs() << "Adding svm arg " << Arg << " of " << F.getName()
1591+
<< "\n");
1592+
m_args.insert(&Arg);
1593+
}
15911594
}

IGC/VectorCompiler/lib/GenXOpts/CMTrans/GenXBTIAssignment.cpp

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ SPDX-License-Identifier: MIT
2828

2929
#include "Probe/Assertion.h"
3030

31+
#include "llvmWrapper/ADT/StringRef.h"
32+
3133
#include <llvm/ADT/StringRef.h>
3234
#include <llvm/IR/Function.h>
3335
#include <llvm/IR/IRBuilder.h>
@@ -114,18 +116,18 @@ static constexpr int MaxAvailableSurfaceIndex = 239;
114116
static constexpr int MaxAvailableSamplerIndex = 14;
115117

116118
static bool isDescImageType(StringRef TypeDesc) {
117-
return TypeDesc.find_lower("image1d_t") != StringRef::npos ||
118-
TypeDesc.find_lower("image2d_t") != StringRef::npos ||
119-
TypeDesc.find_lower("image3d_t") != StringRef::npos ||
120-
TypeDesc.find_lower("image1d_buffer_t") != StringRef::npos;
119+
return IGCLLVM::contains_insensitive(TypeDesc, "image1d_t") ||
120+
IGCLLVM::contains_insensitive(TypeDesc, "image2d_t") ||
121+
IGCLLVM::contains_insensitive(TypeDesc, "image3d_t") ||
122+
IGCLLVM::contains_insensitive(TypeDesc, "image1d_buffer_t");
121123
}
122124

123125
static bool isDescReadOnly(StringRef TypeDesc) {
124-
return TypeDesc.find_lower("read_only") != StringRef::npos;
126+
return IGCLLVM::contains_insensitive(TypeDesc, "read_only");
125127
}
126128

127129
static bool isDescSvmPtr(StringRef TypeDesc) {
128-
return TypeDesc.find_lower("svmptr_t") != StringRef::npos;
130+
return IGCLLVM::contains_insensitive(TypeDesc, "svmptr_t");
129131
}
130132

131133
template <typename ZipTy>

IGC/VectorCompiler/lib/Utils/GenX/Printf.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ SPDX-License-Identifier: MIT
2727
#include <string>
2828

2929
#include "Probe/Assertion.h"
30+
#include "llvmWrapper/ADT/StringRef.h"
3031
#include "llvmWrapper/Support/Regex.h"
3132

3233
using namespace llvm;
@@ -117,10 +118,12 @@ static PrintfArgInfo parseArgDesc(StringRef ArgDesc) {
117118
if (ArgDesc.endswith("d") || ArgDesc.endswith("i"))
118119
return parseIntLengthModifier(ArgDesc, /* IsSigned */ true);
119120
if (ArgDesc.endswith("o") || ArgDesc.endswith("u") ||
120-
ArgDesc.endswith_lower("x"))
121+
IGCLLVM::endswith_insensitive(ArgDesc, "x"))
121122
return parseIntLengthModifier(ArgDesc, /* IsSigned */ false);
122-
if (ArgDesc.endswith_lower("f") || ArgDesc.endswith_lower("e") ||
123-
ArgDesc.endswith_lower("a") || ArgDesc.endswith_lower("g"))
123+
if (IGCLLVM::endswith_insensitive(ArgDesc, "f") ||
124+
IGCLLVM::endswith_insensitive(ArgDesc, "e") ||
125+
IGCLLVM::endswith_insensitive(ArgDesc, "a") ||
126+
IGCLLVM::endswith_insensitive(ArgDesc, "g"))
124127
return {PrintfArgInfo::Double, /* IsSigned */ true};
125128
IGC_ASSERT_MESSAGE(ArgDesc.endswith("p"), "unexpected conversion specifier");
126129
return {PrintfArgInfo::Pointer, /* IsSigned */ false};

IGC/WrapperLLVM/include/llvmWrapper/ADT/StringRef.h

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,22 @@ namespace IGCLLVM
2020
return LHS.equals_lower(RHS);
2121
#else
2222
return LHS.equals_insensitive(RHS);
23+
#endif
24+
}
25+
26+
inline bool endswith_insensitive(llvm::StringRef LHS, llvm::StringRef RHS) {
27+
#if LLVM_VERSION_MAJOR < 13
28+
return LHS.endswith_lower(RHS);
29+
#else
30+
return LHS.endswith_insensitive(RHS);
31+
#endif
32+
}
33+
34+
inline bool contains_insensitive(llvm::StringRef LHS, llvm::StringRef RHS) {
35+
#if LLVM_VERSION_MAJOR < 13
36+
return LHS.contains_lower(RHS);
37+
#else
38+
return LHS.contains_insensitive(RHS);
2339
#endif
2440
}
2541
}

0 commit comments

Comments
 (0)