Skip to content

Commit e2bf619

Browse files
srividyakarumuriigcbot
authored andcommitted
Removing FuseTypedWriteInIGC and merging with FuseTypedWrite
Removing FuseTypedWriteInIGC and merging with FuseTypedWrite
1 parent c34a091 commit e2bf619

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14009,7 +14009,7 @@ void EmitPass::emitTypedWrite(llvm::Instruction* pInsn)
1400914009
m_encoder->SetDstSubVar(3);
1401014010
m_encoder->Copy(pPayload[i], pSrc_W);
1401114011
m_encoder->Push();
14012-
if (IGC_IS_FLAG_DISABLED(FuseTypedWriteInIGC))
14012+
if (!m_currShader->m_Platform->canFuseTypedWrite())
1401314013
{
1401414014
setSIMDSizeMask(m_encoder, m_currShader, i);
1401514015
m_encoder->SetSrcSubVar(0, i);
@@ -14021,7 +14021,7 @@ void EmitPass::emitTypedWrite(llvm::Instruction* pInsn)
1402114021
m_encoder->Push();
1402214022
}
1402314023
}
14024-
if (IGC_IS_FLAG_ENABLED(FuseTypedWriteInIGC))
14024+
if (m_currShader->m_Platform->canFuseTypedWrite())
1402514025
{
1402614026
for (uint i = 0; i < numInst; ++i)
1402714027
{

IGC/Compiler/CISACodeGen/Platform.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ bool NeedsHDCFenceBeforeEOTInPixelShader() const
660660

661661
bool canFuseTypedWrite() const
662662
{
663-
return IGC_IS_FLAG_ENABLED(FuseTypedWrite);
663+
return false;
664664
}
665665

666666
unsigned int getMaxNumberHWThreadForEachWG() const

IGC/common/igc_flags.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -450,8 +450,7 @@ DECLARE_IGC_REGKEY(bool, ForceMixMode, false, "force enable mix mode even on pla
450450
DECLARE_IGC_REGKEY(bool, DisableFDIV, false, "Disable fdiv support", false)
451451
DECLARE_IGC_REGKEY(bool, EmulateFDIV, false, "Emulate fdiv instructions", false)
452452
DECLARE_IGC_REGKEY(bool, UpConvertF16Sampler, true, "up-convert fp16 sampler mesasge to return fp32", false)
453-
DECLARE_IGC_REGKEY(bool, FuseTypedWrite, false, "Enable fusing of simd8 typed write", false)
454-
DECLARE_IGC_REGKEY(bool, FuseTypedWriteInIGC, false, "Enable fusing of simd8 typed write", false)
453+
DECLARE_IGC_REGKEY(bool, FuseTypedWrite, true, "Enable fusing of simd8 typed write", false)
455454
DECLARE_IGC_REGKEY(bool, EnableUndefAlphaOutputAsRed, true, "Output red for undefined alpha output", false)
456455
DECLARE_IGC_REGKEY(bool, EnableHalfPromotion, true, "Enable pass that replaces instructions using halfs with corresponding float counterparts for pre-SKL", false)
457456
DECLARE_IGC_REGKEY(bool, ForceHalfPromotion, false, "Force enable pass that replaces instructions using halfs with corresponding float counterparts", false)

0 commit comments

Comments
 (0)