Skip to content

Commit ae3d230

Browse files
committed
Update verifier check for typed gather/scatter
Change-Id: I43d13cf2acff36e5ea88acd63d2c664a0660ef4d
1 parent a1689c8 commit ae3d230

File tree

1 file changed

+0
-29
lines changed

1 file changed

+0
-29
lines changed

visa/IsaVerification.cpp

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2642,40 +2642,11 @@ static void verifyInstructionDataport(const common_isa_header& isaHeader,
26422642
ch_mask = ch_mask & 0xF;
26432643
REPORT_INSTRUCTION(options,ch_mask != 0x0, "At least one channel must be enabled for TYPED GATEHR4/SCATTER4");
26442644

2645-
auto execSize = (Common_ISA_Exec_Size)(inst->execsize & 0xF);
2646-
REPORT_INSTRUCTION(options,
2647-
execSize == EXEC_SIZE_8,
2648-
"Only support SIMD8 mode for TYPED GATEHR4/SCATTER4");
2649-
26502645
surface = getPrimitiveOperand<uint8_t>(inst, i++);
26512646
REPORT_INSTRUCTION(options, (0 != surface && 5 != surface), "Surface T0/T5 (the SLM surface) is not allowed for TYPED SCATTTER4/GATHER4");
26522647
REPORT_INSTRUCTION(options,surface < numPreDefinedSurfs + header->getSurfaceCount(),
26532648
"CISA dataport TYPED SCATTTER4/GATHER4 instruction uses an undeclared surface.");
26542649
}
2655-
else
2656-
{
2657-
uint8_t ch_mask = 0;
2658-
uint8_t num_elts = 0;
2659-
2660-
ch_mask = getPrimitiveOperand<uint8_t>(inst, i++);
2661-
ch_mask = ch_mask & 0xF;
2662-
REPORT_INSTRUCTION(options,ch_mask != 0xF, "At least one channel must be enabled");
2663-
2664-
num_elts = getPrimitiveOperand<uint8_t>(inst, i++);
2665-
num_elts = num_elts & 0x3;
2666-
2667-
if (num_elts == 0) num_elts = 8;
2668-
else if (num_elts == 1) num_elts = 16;
2669-
else REPORT_INSTRUCTION(options,false, "Illegal number of elements used in GATHER4/SCATTER4 instruction.");
2670-
2671-
REPORT_INSTRUCTION(options,num_elts == 8, "Only support SIMD8 mode for typed gather4/scatter4.");
2672-
2673-
surface = getPrimitiveOperand<uint8_t>(inst, i++);
2674-
REPORT_INSTRUCTION(options,0 != surface, "Surface T0 (the SLM surface) is not allowed for TYPED SCATTTER4/GATHER4");
2675-
REPORT_INSTRUCTION(options,surface < numPreDefinedSurfs + header->getSurfaceCount(),
2676-
"CISA dataport TYPED SCATTTER4/GATHER4 instruction uses an undeclared surface.");
2677-
}
2678-
26792650
break;
26802651
}
26812652
case ISA_GATHER4_SCALED:

0 commit comments

Comments
 (0)