Skip to content

Commit 73b4d7b

Browse files
sys-igcigcbot
authored andcommitted
[Autobackout][FunctionalRegression]Revert of change: 777fa89: Add error for printf unsupported addr space
Implement the error msg when for printf() is used private address space. Currently, IGC supports global or constant address space for printf(). Support for private addr space can be added in the future.
1 parent 8ff0409 commit 73b4d7b

File tree

2 files changed

+1
-52
lines changed

2 files changed

+1
-52
lines changed

IGC/Compiler/Optimizer/OpenCLPasses/OpenCLPrintf/OpenCLPrintfResolution.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -391,9 +391,7 @@ void OpenCLPrintfResolution::removeExcessArgs()
391391

392392
Value* formatString = formatStringArgDesc->value;
393393
IGC::SHADER_PRINTF_TYPE dataType = formatStringArgDesc->argType;
394-
if (dataType != SHADER_PRINTF_STRING_LITERAL) {
395-
m_CGContext->EmitError("First printf argument has to contain a string literal.", formatString);
396-
}
394+
IGC_ASSERT(dataType == SHADER_PRINTF_STRING_LITERAL);
397395

398396
if (auto GV = dyn_cast<GlobalVariable>(formatString))
399397
{

IGC/Compiler/tests/OpenCLPrintfResolution/printf_with_invalid_pointer_address_space.ll

Lines changed: 0 additions & 49 deletions
This file was deleted.

0 commit comments

Comments
 (0)