Skip to content

fix: update only allow.txt with new words - #5070

Closed
Shrishti1701 wants to merge 5 commits into
ossf:mainfrom
Shrishti1701:fix-spelling-issue-5044
Closed

Shrishti1701 wants to merge 5 commits into
ossf:mainfrom
Shrishti1701:fix-spelling-issue-5044

Conversation

@Shrishti1701

@Shrishti1701 Shrishti1701 commented May 5, 2025 •

Copy link
Copy Markdown
Contributor

@terriko
Fixed a spelling mistake in the CLI help message related to vulnerability scanning. This closes issue #5044.

@terriko terriko changed the title Fix: Remove unintended changes to expect.txt, update only allow.txt fix: Remove unintended changes to expect.txt, update only allow.txt May 6, 2025
@terriko terriko changed the title fix: Remove unintended changes to expect.txt, update only allow.txt fix: update only allow.txt with new words May 6, 2025

@terriko terriko left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spellcheck error is hard to read but...

Unrecognized words (1)\n\nsboms\n\n

These words are not needed and should be removed\naar aiohttp cdx cwes cyclonedx getbootstrap GMS Interoperability NOTKNOWN pyyaml rdf sbom skontar spdx Svunknown swid urllib \n

@Shrishti1701

Copy link
Copy Markdown
Contributor Author

@terriko I deleted the unrecognized word from the allow.txt.

@Shrishti1701
Shrishti1701 force-pushed the fix-spelling-issue-5044 branch from a98b85e to 1161c3d Compare May 7, 2025 05:38

@terriko terriko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CDX got removed by mistake (possibly also SPDX?) and you'll need to keep the blank line after zstd because it won't work without it. (I think we have that documented but it is easy to miss. It's a quirk of the workflow we're using.)

@Shrishti1701

Copy link
Copy Markdown
Contributor Author

Thanks for catching that! I’ll go ahead and re-add CDX (and SPDX if needed), and make sure to include the blank line after zstd. Appreciate the heads-up on that quirk — I’ll refer to the documentation going forward to avoid missing it again.

@mastersans

Copy link
Copy Markdown
Collaborator

Hi @Shrishti1701 Any Updates on this?

@Shrishti1701

Copy link
Copy Markdown
Contributor Author

Hi,@mastersans
I'm currently not working on this pull request. Please feel free to reassign it if needed.

@mastersans mastersans closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants