fix: disable compression for exported allocations

Related-To: NEO-12021

Signed-off-by: Szymon Morek <[email protected]>

Author: smorek-intel

level_zero/core/test/unit_tests/sources/memory/test_memory.cpp

@@ -3154,7 +3154,10 @@ TEST_F(MemoryExportImportTest,
                                                  size, alignment, &ptr);
     EXPECT_EQ(ZE_RESULT_SUCCESS, result);
     EXPECT_NE(nullptr, ptr);
-
+    auto allocData = context->getDriverHandle()->getSvmAllocsManager()->getSVMAlloc(ptr);
+    EXPECT_NE(nullptr, allocData);
+    auto allocation = allocData->gpuAllocations.getDefaultGraphicsAllocation();
+    EXPECT_FALSE(allocation->isCompressionEnabled());
     result = context->freeMem(ptr);
     EXPECT_EQ(ZE_RESULT_SUCCESS, result);
 

shared/source/memory_manager/memory_manager.h

@@ -306,6 +306,8 @@ class MemoryManager {
     virtual bool createMediaContext(uint32_t rootDeviceIndex, void *controlSharedMemoryBuffer, uint32_t controlSharedMemoryBufferSize, void *controlBatchBuffer, uint32_t controlBatchBufferSize, uint64_t &outDoorbell) { return false; }
     virtual bool releaseMediaContext(uint32_t rootDeviceIndex, uint64_t doorbellHandle) { return false; }
 
+    virtual bool isCompressionSupportedForShareable(bool isShareable) { return true; }
+
   protected:
     bool getAllocationData(AllocationData &allocationData, const AllocationProperties &properties, const void *hostPtr, const StorageInfo &storageInfo);
     static void overrideAllocationData(AllocationData &allocationData, const AllocationProperties &properties);

shared/source/memory_manager/unified_memory_manager.cpp

@@ -294,6 +294,7 @@ void *SVMAllocsManager::createUnifiedMemoryAllocation(size_t size,
     unifiedMemoryProperties.cacheRegion = MemoryPropertiesHelper::getCacheRegion(memoryProperties.allocationFlags);
     unifiedMemoryProperties.flags.uncacheable = memoryProperties.allocationFlags.flags.locallyUncachedResource;
     unifiedMemoryProperties.flags.preferCompressed = compressionEnabled || memoryProperties.allocationFlags.flags.compressedHint;
+    unifiedMemoryProperties.flags.preferCompressed &= memoryManager->isCompressionSupportedForShareable(memoryProperties.allocationFlags.flags.shareable);
     unifiedMemoryProperties.flags.resource48Bit = memoryProperties.allocationFlags.flags.resource48Bit;
 
     if (memoryProperties.memoryType == InternalMemoryType::deviceUnifiedMemory) {

shared/source/os_interface/linux/drm_memory_manager.cpp

@@ -2740,4 +2740,9 @@ bool DrmMemoryManager::releaseMediaContext(uint32_t rootDeviceIndex, uint64_t do
     return getDrm(rootDeviceIndex).getIoctlHelper()->releaseMediaContext(doorbellHandle);
 }
 
+bool DrmMemoryManager::isCompressionSupportedForShareable(bool isShareable) {
+    // Currently KMD does not support compression with allocation sharing
+    return !isShareable;
+}
+
 } // namespace NEO

shared/source/os_interface/linux/drm_memory_manager.h

@@ -104,6 +104,8 @@ class DrmMemoryManager : public MemoryManager {
     bool createMediaContext(uint32_t rootDeviceIndex, void *controlSharedMemoryBuffer, uint32_t controlSharedMemoryBufferSize, void *controlBatchBuffer, uint32_t controlBatchBufferSize, uint64_t &outDoorbell) override;
     bool releaseMediaContext(uint32_t rootDeviceIndex, uint64_t doorbellHandle) override;
 
+    bool isCompressionSupportedForShareable(bool isShareable) override;
+
   protected:
     void registerSharedBoHandleAllocation(DrmAllocation *drmAllocation);
     BufferObjectHandleWrapper tryToGetBoHandleWrapperWithSharedOwnership(int boHandle);

shared/test/unit_test/memory_manager/memory_manager_tests.cpp

@@ -3204,4 +3204,10 @@ TEST(AllocationListTest, givenAllocationInListWhenFreeAllGraphicsAllocationsCall
     EXPECT_EQ(nullptr, allocList.peekHead());
     EXPECT_EQ(nullptr, allocList.peekTail());
     EXPECT_TRUE(allocList.peekIsEmpty());
+}
+
+TEST(MemoryManagerTest, givenIsCompressionSupportedForShareableThenReturnTrue) {
+    MockMemoryManager memoryManager;
+    EXPECT_TRUE(memoryManager.isCompressionSupportedForShareable(true));
+    EXPECT_TRUE(memoryManager.isCompressionSupportedForShareable(false));
 }

shared/test/unit_test/os_interface/linux/drm_memory_manager_tests.cpp

@@ -7929,3 +7929,8 @@ TEST_F(DrmMemoryManagerTest, givenDebugVariableToToggleGpuVaBitsWhenAllocatingRe
         memoryManager->freeGraphicsMemory(allocation);
     }
 }
+
+TEST_F(DrmMemoryManagerTest, givenIsCompressionSupportedForShareableThenReturnCorrectValue) {
+    EXPECT_FALSE(memoryManager->isCompressionSupportedForShareable(true));
+    EXPECT_TRUE(memoryManager->isCompressionSupportedForShareable(false));
+}