[BUG]: v6.7.4 causes Internal validation error during TF Init

[AndrewUnderwoodAtFanatics]

Expected Behavior

I would expect TF that was working prior to the v6.7.0 release would resume working after the v6.7.4 fix.

v6.7.0, v6.7.1, v6.7.2, and v6.7.3 gave us errors at the end of the apply but unfortunately v6.7.4 is giving us errors at the beginning of the plan.

Actual Behavior

Error: InternalValidate

  with provider["registry.terraform.io/integrations/github"].xxx

Internal validation of the provider failed! This is always a bug
with the provider itself, and not a user issue. Please report
this bug:

resource github_actions_organization_secret: All fields are ForceNew or
Computed w/out Optional, Update is superfluous
resource github_actions_secret: All fields are ForceNew or Computed w/out
Optional, Update is superfluous

Error: InternalValidate

  with provider["registry.terraform.io/integrations/github"].xxx,
  on main.tf line 44, in provider "github":
  44: provider "github" {

Internal validation of the provider failed! This is always a bug
with the provider itself, and not a user issue. Please report
this bug:

resource github_actions_organization_secret: All fields are ForceNew or
Computed w/out Optional, Update is superfluous
resource github_actions_secret: All fields are ForceNew or Computed w/out
Optional, Update is superfluous

Module versions in this stack

  - Using olivr/gpg v0.2.1 from the shared cache directory
  - Using mastercard/restapi v2.0.1 from the shared cache directory
  - Using tchupp/env v0.0.2 from the shared cache directory
  - Using hashicorp/aws v5.6.2 from the shared cache directory
  - Using integrations/github v6.7.4 from the shared cache directory <---- integrations/github v6.7.4
  - Using hashicorp/tls v4.1.0 from the shared cache directory
  - Using datadog/datadog v3.78.0 from the shared cache directory

Terraform Version

Terraform v1.13.4
on linux_amd64

Affected Resource(s)

• github_actions_organization_secret

Terraform Configuration Files

I'm sorry, I can't share this publicly but I can share privately if there's a way to accomplish this.

Steps to Reproduce

No response

Debug Output

Panic Output

Code of Conduct

• I agree to follow this project's Code of Conduct

[zepeng811]

experiencing the same issue and also posted in #2839 (comment)

reverting to v6.7.0 works.

[AndrewUnderwoodAtFanatics]

Unfortunately when trying to revert to v6.7.0 I get a whole bunch of state errors for resources that have already been upgraded.

Error: Resource instance managed by newer provider version
The current state of
module.infrastructure.github_actions_secret.xxxxxx[0]
was created by a newer provider version than is currently selected. Upgrade
the github provider to work with this state.

[scrthq]

@AndrewUnderwoodAtFanatics Looks like going 1 version back to 6.7.3 works as well, currently sanity testing on my end. Will confirm shortly.

[AndrewUnderwoodAtFanatics]

Reverting to 6.7.3 is an improvement but still results in the previous issues with that release that have been reported. At the end of the apply phase we get failures one all github_actions_secret resources.

│ When applying changes to
│ module.infrastructure.github_actions_secret.AAAA[0],
│ provider "provider[\"registry.terraform.io/integrations/github\"]" produced
│ an unexpected new value: Root object was present, but now absent.
│ 
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.
╵
╷
│ Error: Provider produced inconsistent result after apply
│ 
│ When applying changes to
│ module.infrastructure.github_actions_secret.BBBB[0],
│ provider "provider[\"registry.terraform.io/integrations/github\"]" produced
│ an unexpected new value: Root object was present, but now absent.
│ 
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.

[nickfloyd]

Thank you for the info @AndrewUnderwoodAtFanatics - I now realized that I pushed the fix without removing the now useless update func. This is the diff that I'll cut a new release for:

Validated by:

git checkout v6.7.4
go build -o terraform-provider-github
terraform init && terraform validate

Errored with the update validation failure

git checkout v6.7.5-patch
go build -o terraform-provider-github
terraform init && terraform validate

No validation errors

v6.7.4...v6.7.5-patch

[nickfloyd]

https://github.com/integrations/terraform-provider-github/releases/tag/v6.7.5

I've also realized that there is a hole in our CI testing - I'll be adding the running of terraform configuration validation to our PR CI loop - #2856

Apologies for the trouble and thank you for the quick response on getting logs and the details of this issue.