-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Resource github_organization_ruleset
knows nothing about attribute required_workflows
after creation of the Rule(s)
#2113
Comments
Hey @ViacheslavKudinov, I'll try looking into this within the next couple of days, it's likely an issue with how the object is serialized. Thanks for bringing this up 🙂 |
github_organization_ruleset
knows nothing about attribute resource after creation of the Rule(s)github_organization_ruleset
knows nothing about attribute required_workflows
after creation of the Rule(s)
github_organization_ruleset
knows nothing about attribute required_workflows
after creation of the Rule(s)github_organization_ruleset
knows nothing about attribute required_workflows
after creation of the Rule(s)
Thank you @o-sama, it will be great if you could fix it quickly. |
Is not reproducible on v6.0.1. |
@ViacheslavKudinov feel free to close the issue if this has been fixed! |
Thanks for the fix. |
Hey @kfcampbell , @o-sama , @ViacheslavKudinov Edit: We are using terraform_version: "1.7.5" |
Hm, |
Interesting! Did you create is a new ruleset or import an existing one? Let me test creating a new ruleset from scratch and see if that works. |
I didn't create or import anything new. If it is about import or creation of a new resource, then maybe exactly this scenario needs more testing. My initial issue i reported was that plan/apply was always trying to "add" object |
Okay. We are still experiencing this issue. @kfcampbell should this issue be re-opened or should I create a new one? We are using: Code that we are using. (And this code is applied!):
and terraform plan with no changes to this resource code:
terraform state shows null for this resource's required_workflows block ("required_workflows": null) |
I'll re-open then. |
Apologies for ghosting this. I've been going through a rough period with the baby and just last week the company I work at announced it is being dissolved. On the bright side that means I should have more free time now to contribute so I should be more consistent 🤣, I'll try to work on this in the next couple of days and hopefully figure out where this is going wrong |
Ran it using the TF and provider versions you mentioned @anttijman, the state is stored as follows with the same rule you've defined: I now have a direction on where this is going wrong and will try to get a fix out tonight :) |
Once @kfcampbell or @nickfloyd have a chance to review this should be good to go :) |
any news? |
Expected Behaviour
Terraform state has information about an attribute required_workflows of the github_organization_rulesett resource.
Actual Behaviour
State DOES NOT include information about
required_workflows
attribute ofgithub_organization_ruleset
resource.Terraform Version
Terraform
v1.7.0
on linux_amd64GH Provider registry.terraform.io/integrations/github
v5.45.0
Affected Resource(s)
Terraform Configuration Files
Steps to Reproduce
output of plan (tries to add
required_workflow
again)output of state (empty
rules
object)Debug Output
No response
Panic Output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: