Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependency builder in aggregator #2254

Open
2 tasks
jpraynaud opened this issue Jan 27, 2025 · 0 comments
Open
2 tasks

Simplify dependency builder in aggregator #2254

jpraynaud opened this issue Jan 27, 2025 · 0 comments
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jan 27, 2025

Why

The dependency injection builder in the aggregator is too cumbersome and hard to navigate/work with. We need to simplify it for a better maintainability.

What

Split the builder module of the dependency_injection in sub-modules.

How

  • Create a sub module for the DependenciesBuilder struct definition
  • Create new sub-modules based on the existing modules in the crate (e.g. artifact_builder.rs which builds the dependencies originating from the artifact_builder module) which a new impl block for the DependenciesBuilder

Later

  • Have a clear separation between traits and their implementations in the builder
  • Use of macros to create the dependency building code?
  • Better support of execution environment (test/prod)
@jpraynaud jpraynaud added the refactoring 🛠️ Code refactoring and enhancements label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Development

No branches or pull requests

1 participant