-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathAtomTrigger.childMode.test.tsx
More file actions
367 lines (306 loc) · 11.2 KB
/
Copy pathAtomTrigger.childMode.test.tsx
File metadata and controls
367 lines (306 loc) · 11.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
import React from 'react';
import { act, fireEvent, render } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { AtomTrigger } from './index';
import {
finishDomTestRun,
prepareDomTestRun,
scrollElement,
setNodeEnv,
setRect,
setupChildRootHarness,
} from './AtomTrigger.testUtils';
import { warningMessages } from './AtomTrigger.warnings';
beforeEach(() => {
prepareDomTestRun();
});
afterEach(() => {
finishDomTestRun();
});
describe('AtomTrigger child mode', () => {
it('preserves the child ref while observing the child node', () => {
const childRef = React.createRef<HTMLDivElement>();
const { child } = setupChildRootHarness({ childRef });
expect(childRef.current).toBe(child);
});
it('observes a React 19-style component that passes ref through props', async () => {
const onEnter = vi.fn();
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
const rootRef = React.createRef<HTMLDivElement>();
let scrollTop = 0;
function RefPropChild(props: { ref?: React.Ref<HTMLDivElement> }) {
return (
<div data-testid="react19-ref-child" ref={props.ref}>
child
</div>
);
}
const view = render(
<div ref={rootRef} data-testid="root">
<AtomTrigger rootRef={rootRef} onEnter={onEnter}>
<RefPropChild />
</AtomTrigger>
</div>,
);
const root = view.getByTestId('root');
const child = view.getByTestId('react19-ref-child');
if (!(root instanceof HTMLDivElement) || !(child instanceof HTMLDivElement)) {
throw new Error('React 19 child harness not found');
}
setRect(root, () => new DOMRect(0, 0, 200, 200));
setRect(child, () => new DOMRect(0, 260 - scrollTop, 20, 100));
await act(async () => {
await Promise.resolve();
});
scrollTop = 135;
fireEvent.scroll(root);
expect(onEnter).toHaveBeenCalledTimes(1);
expect(warn).not.toHaveBeenCalledWith(
'[react-atom-trigger] Child mode expects a DOM element or a component that forwards its ref to a DOM element. Observation is disabled for this render.',
);
});
it('warns when a forwarded ref resolves to a pseudo-DOM handle instead of crashing', () => {
setNodeEnv('development');
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
const error = vi.spyOn(console, 'error').mockImplementation(() => {});
const rootRef = React.createRef<HTMLDivElement>();
const ImperativeHandleChild = React.forwardRef<{ nodeType: number }>((_props, ref) => {
React.useImperativeHandle(
ref,
() => ({
nodeType: 1,
}),
[],
);
return <div data-testid="imperative-handle-child">child</div>;
});
const view = render(
<div ref={rootRef} data-testid="root">
<AtomTrigger rootRef={rootRef}>
<ImperativeHandleChild />
</AtomTrigger>
</div>,
);
expect(view.getByTestId('imperative-handle-child')).toBeTruthy();
expect(warn).toHaveBeenCalledWith(warningMessages.nonDomChildRef);
expect(error).not.toHaveBeenCalled();
});
it('does not warn when a child resolves to a DOM node after an async placeholder render', async () => {
setNodeEnv('development');
vi.useFakeTimers();
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
const rootRef = React.createRef<HTMLDivElement>();
const DelayedDomChild = React.forwardRef<HTMLDivElement>((_props, ref) => {
const [ready, setReady] = React.useState(false);
React.useEffect(() => {
const timeoutId = window.setTimeout(() => {
setReady(true);
}, 0);
return () => {
window.clearTimeout(timeoutId);
};
}, []);
if (!ready) {
return null;
}
return (
<div data-testid="delayed-dom-child" ref={ref}>
child
</div>
);
});
const view = render(
<div ref={rootRef} data-testid="root">
<AtomTrigger rootRef={rootRef}>
<DelayedDomChild />
</AtomTrigger>
</div>,
);
const root = view.getByTestId('root');
if (!(root instanceof HTMLDivElement)) {
throw new Error('Delayed child root not found');
}
setRect(root, () => new DOMRect(0, 0, 200, 200));
await act(async () => {
vi.advanceTimersByTime(0);
});
const child = view.getByTestId('delayed-dom-child');
if (!(child instanceof HTMLDivElement)) {
throw new Error('Delayed child not found');
}
await act(async () => {
await Promise.resolve();
});
await act(async () => {
vi.advanceTimersByTime(16);
});
expect(
warn.mock.calls.some(([message]) => message === warningMessages.unsupportedChildRef),
).toBe(false);
});
it('warns and ignores className in child mode', () => {
setNodeEnv('development');
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
const view = render(
<AtomTrigger className="atom-trigger-sentinel">
<div data-testid="observed-child">child</div>
</AtomTrigger>,
);
const child = view.getByTestId('observed-child');
expect(child.className).toBe('');
expect(warn).toHaveBeenCalledWith(
'[react-atom-trigger] `className` only applies to the internal sentinel. In child mode, style the child element directly.',
);
});
it('keeps child mode warnings silent when development is not explicitly known', () => {
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
const view = render(
<AtomTrigger className="atom-trigger-sentinel">
<div data-testid="observed-child">child</div>
</AtomTrigger>,
);
const child = view.getByTestId('observed-child');
expect(child.className).toBe('');
expect(warn).toHaveBeenCalledTimes(0);
});
it('dedupes repeated child mode warnings in development', () => {
setNodeEnv('development');
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
const message =
'[react-atom-trigger] `className` only applies to the internal sentinel. In child mode, style the child element directly.';
const view = render(
<AtomTrigger className="atom-trigger-sentinel">
<div data-testid="observed-child">child</div>
</AtomTrigger>,
);
view.rerender(
<AtomTrigger className="atom-trigger-sentinel">
<div data-testid="observed-child">child</div>
</AtomTrigger>,
);
expect(warn.mock.calls.filter(([warning]) => warning === message)).toHaveLength(1);
});
it('treats boolean children as empty sentinel mode instead of invalid child mode', () => {
setNodeEnv('development');
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
const view = render(<AtomTrigger className="atom-trigger-sentinel">{false}</AtomTrigger>);
expect(view.container.querySelector('.atom-trigger-sentinel')).toBeInstanceOf(HTMLDivElement);
expect(warn).not.toHaveBeenCalled();
});
it('cleans up child observation when a previously observed child stops exposing a DOM node', async () => {
const onEnter = vi.fn();
const rootRef = React.createRef<HTMLDivElement>();
let scrollTop = 0;
const ObservedChild = React.forwardRef<HTMLDivElement>((_props, ref) => (
<div data-testid="switchable-child" ref={ref}>
child
</div>
));
function PlainChild() {
return <div data-testid="switchable-child">child</div>;
}
const view = render(
<div ref={rootRef} data-testid="root">
<AtomTrigger rootRef={rootRef} onEnter={onEnter}>
<ObservedChild />
</AtomTrigger>
</div>,
);
const root = view.getByTestId('root');
const child = view.getByTestId('switchable-child');
if (!(root instanceof HTMLDivElement) || !(child instanceof HTMLDivElement)) {
throw new Error('Switchable child harness not found');
}
setRect(root, () => new DOMRect(0, 0, 200, 200));
setRect(child, () => new DOMRect(0, 260 - scrollTop, 20, 100));
await act(async () => {
await Promise.resolve();
});
scrollTop = 135;
fireEvent.scroll(root);
expect(onEnter).toHaveBeenCalledTimes(1);
view.rerender(
<div ref={rootRef} data-testid="root">
<AtomTrigger rootRef={rootRef} onEnter={onEnter}>
<PlainChild />
</AtomTrigger>
</div>,
);
scrollTop = 0;
fireEvent.scroll(root);
expect(onEnter).toHaveBeenCalledTimes(1);
});
it.each([
{
label: 'multiple top-level children',
expected:
'[react-atom-trigger] Child mode expects exactly one top-level React element. Observation is disabled for this render.',
renderChildren: () => [
<div key="first" data-testid="first-child" />,
<div key="second" data-testid="second-child" />,
],
assertContent: (view: ReturnType<typeof render>) => {
expect(view.getByTestId('first-child')).toBeTruthy();
expect(view.getByTestId('second-child')).toBeTruthy();
},
},
{
label: 'a fragment child',
expected:
'[react-atom-trigger] Child mode does not support React.Fragment. Wrap the content in a single DOM element. Observation is disabled for this render.',
renderChildren: () => (
<>
<div data-testid="fragment-child" />
</>
),
assertContent: (view: ReturnType<typeof render>) => {
expect(view.getByTestId('fragment-child')).toBeTruthy();
},
},
{
label: 'a text child',
expected:
'[react-atom-trigger] Child mode expects a React element child. Observation is disabled for this render.',
renderChildren: () => 'plain text child',
assertContent: (view: ReturnType<typeof render>) => {
expect(view.container.textContent).toContain('plain text child');
},
},
{
label: 'a custom child without ref forwarding',
expected:
'[react-atom-trigger] Child mode expects a DOM element or a component that forwards its ref to a DOM element. Observation is disabled for this render.',
renderChildren: () => {
function PlainChild() {
return <div data-testid="plain-child" />;
}
return <PlainChild />;
},
assertContent: (view: ReturnType<typeof render>) => {
expect(view.getByTestId('plain-child')).toBeTruthy();
},
},
])('warns and skips observation for $label', ({ expected, renderChildren, assertContent }) => {
setNodeEnv('development');
vi.useFakeTimers();
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
const onEnter = vi.fn();
const rootRef = React.createRef<HTMLDivElement>();
const view = render(
<div ref={rootRef} data-testid="root">
<AtomTrigger rootRef={rootRef} onEnter={onEnter}>
{renderChildren()}
</AtomTrigger>
</div>,
);
const root = view.getByTestId('root');
setRect(root, () => new DOMRect(0, 0, 200, 200));
scrollElement(root, 120);
act(() => {
vi.runAllTimers();
});
assertContent(view);
expect(onEnter).toHaveBeenCalledTimes(0);
expect(warn.mock.calls.some(([warning]) => warning === expected)).toBe(true);
});
});