Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy trigger logs are nested sentences #8812

Open
edvgui opened this issue Mar 5, 2025 · 2 comments
Open

Deploy trigger logs are nested sentences #8812

edvgui opened this issue Mar 5, 2025 · 2 comments
Labels
discussion There is a discussion happening on this issue

Comments

@edvgui
Copy link
Contributor

edvgui commented Mar 5, 2025

The logs of a resource showing the reason of the deploy currently look like this:

Start run for resource ... because Deploy was triggered because a new version has been released
Start run for resource ... because Deploy was triggered because user has requested a deploy
Start run for resource ... because Individual deploy triggered for resource ... because last deploy happened more than 600s ago.

It looks like there is a second log starting in the middle of the log (after the first because). This is a bit silly, it could for example be changed to:

Deploy was triggered because a new version has been released: %(version)s
Deploy was triggered because user has requested a deploy
Individual deploy triggered because last deploy happened more than 600s ago.

I think the second half of the log is plenty enough, and it doesn't need to also include the resource id, we already know which resource this is about (log prefix in files or resource page in the web-console)

@wouterdb
Copy link
Contributor

If you read the resource action log, you don't know which resource the log line belongs to if we remove this...

@wouterdb wouterdb added the discussion There is a discussion happening on this issue label Mar 13, 2025
@edvgui
Copy link
Contributor Author

edvgui commented Mar 13, 2025

If you read the resource action log, you don't know which resource the log line belongs to if we remove this...

Oh, I thought the log would have the same prefix as all other resource action logs. But if that is not the case then indeed something about the resource needs to stay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion There is a discussion happening on this issue
Projects
None yet
Development

No branches or pull requests

2 participants