Skip to content

Commit 90fa4d1

Browse files
committed
outstanding TODOs
1 parent 5f04cac commit 90fa4d1

File tree

5 files changed

+7
-4
lines changed

5 files changed

+7
-4
lines changed

test/Passage.t.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ contract PassageTest is SignetStdTest {
3939
// setup token
4040
token = address(HOST_WETH);
4141
// mint WETH by sending ETH
42+
// TODO - this will fail until real WETH is deployed for the test SignetStd
4243
payable(token).sendValue(amount * 10000);
4344
TestERC20(token).approve(address(target), amount * 10000);
4445

test/Permit2Orders.t.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ contract OrderOriginPermit2Test is Permit2Helpers {
2929

3030
function setUp() public virtual {
3131
vm.createSelectFork("https://ethereum-rpc.publicnode.com");
32+
// TODO: fork from .env values
3233
setupStd();
3334

3435
// setup Orders contract

test/Permit2Passage.t.sol

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ contract PassagePermit2Test is Permit2Helpers {
2929

3030
function setUp() public virtual {
3131
vm.createSelectFork("https://ethereum-rpc.publicnode.com");
32-
// re-setup Std after forking -- TODO -- change this so that setupStd() does the forking itself? idk?
32+
// TODO: fork from .env values
3333
setupStd();
3434

3535
// setup Passage
@@ -115,6 +115,7 @@ contract RollupPassagePermit2Test is Permit2Helpers {
115115

116116
function setUp() public virtual {
117117
vm.createSelectFork("https://ethereum-rpc.publicnode.com");
118+
// TODO: fork from .env values
118119
setupStd();
119120

120121
// setup RollupPassage

test/SignetStd.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ library PecorinoConstants {
4747
/// @notice WETH token for the Pecorino testnet host chain.
4848
IERC20 constant HOST_WETH = IERC20(0x572C4d72080ed9E9997509b583a22B785B70cB3f);
4949

50-
// TODO
50+
// TODO - set actual values on pecorino
5151
/// @notice The token admin address, used for configuring tokens on Passage and for withdrawals.
5252
address constant TOKEN_ADMIN = address(0);
5353
/// @notice The gas admin address, used for configuring gas limits on Transactor.

test/SignetStdTest.t.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ contract SignetStdTest is SignetStd, Test {
2222
ROLLUP_ORDERS = new RollupOrders(PERMIT2);
2323
ROLLUP_WETH = new TestERC20("Wrapped Ether", "WETH", 18);
2424
ROLLUP_WBTC = new TestERC20("Wrapped Bitcoin", "WBTC", 8);
25-
ROLLUP_WUSD = new TestERC20("Wrapped USD", "WUSD", 18);
25+
ROLLUP_WUSD = new TestERC20("Wrapped USD", "WUSD", 18); // TODO: make it a real WETH!!
2626

2727
HOST_CHAIN_ID = 31337; // Localhost chain ID
2828
HOST_USDC = new TestERC20("USD Coin", "USDC", 6);
2929
HOST_USDT = new TestERC20("Tether USD", "USDT", 6);
3030
HOST_WBTC = new TestERC20("Wrapped Bitcoin", "WBTC", 8);
31-
HOST_WETH = new TestERC20("Wrapped Ether", "WETH", 18);
31+
HOST_WETH = new TestERC20("Wrapped Ether", "WETH", 18); // TODO: make it a real WETH!!
3232
TOKEN_ADMIN = address(this);
3333
GAS_ADMIN = address(this);
3434
SEQUENCER_ADMIN = address(this);

0 commit comments

Comments
 (0)