outstanding TODOs

Author: anna-carroll

test/Passage.t.sol

@@ -39,6 +39,7 @@ contract PassageTest is SignetStdTest {
         // setup token
         token = address(HOST_WETH);
         // mint WETH by sending ETH
+        // TODO - this will fail until real WETH is deployed for the test SignetStd
         payable(token).sendValue(amount * 10000);
         TestERC20(token).approve(address(target), amount * 10000);
 

test/Permit2Orders.t.sol

@@ -12,6 +12,7 @@ import {ERC20} from "openzeppelin-contracts/contracts/token/ERC20/ERC20.sol";
 import {Test, console2} from "forge-std/Test.sol";
 import {IERC20} from "openzeppelin-contracts/contracts/token/ERC20/IERC20.sol";
 
+// TODO: local tests will fail until Permit2 is etched
 contract OrderOriginPermit2Test is Permit2Helpers {
     RollupOrders public target;
 

test/Permit2Passage.t.sol

@@ -13,6 +13,7 @@ import {ERC20Burnable} from "openzeppelin-contracts/contracts/token/ERC20/extens
 import {Test, console2} from "forge-std/Test.sol";
 import {Address} from "openzeppelin-contracts/contracts/utils/Address.sol";
 
+// TODO: local tests will fail until Permit2 is etched
 contract PassagePermit2Test is Permit2Helpers {
     using Address for address payable;
 
@@ -29,7 +30,6 @@ contract PassagePermit2Test is Permit2Helpers {
 
     function setUp() public virtual {
         vm.createSelectFork("https://ethereum-rpc.publicnode.com");
-        // re-setup Std after forking -- TODO -- change this so that setupStd() does the forking itself? idk?
         setupStd();
 
         // setup Passage
@@ -103,6 +103,7 @@ contract PassagePermit2Test is Permit2Helpers {
     }
 }
 
+// TODO: local tests will fail until Permit2 is etched
 contract RollupPassagePermit2Test is Permit2Helpers {
     RollupPassage public target;
 

test/SignetStd.sol

@@ -47,7 +47,7 @@ library PecorinoConstants {
     /// @notice WETH token for the Pecorino testnet host chain.
     IERC20 constant HOST_WETH = IERC20(0x572C4d72080ed9E9997509b583a22B785B70cB3f);
 
-    // TODO
+    // TODO - set actual values on pecorino
     /// @notice The token admin address, used for configuring tokens on Passage and for withdrawals.
     address constant TOKEN_ADMIN = address(0);
     /// @notice The gas admin address, used for configuring gas limits on Transactor.

test/SignetStdTest.t.sol

@@ -22,13 +22,13 @@ contract SignetStdTest is SignetStd, Test {
             ROLLUP_ORDERS = new RollupOrders(PERMIT2);
             ROLLUP_WETH = new TestERC20("Wrapped Ether", "WETH", 18);
             ROLLUP_WBTC = new TestERC20("Wrapped Bitcoin", "WBTC", 8);
-            ROLLUP_WUSD = new TestERC20("Wrapped USD", "WUSD", 18);
+            ROLLUP_WUSD = new TestERC20("Wrapped USD", "WUSD", 18); // TODO: make it a real WETH!
 
             HOST_CHAIN_ID = 31337; // Localhost chain ID
             HOST_USDC = new TestERC20("USD Coin", "USDC", 6);
             HOST_USDT = new TestERC20("Tether USD", "USDT", 6);
             HOST_WBTC = new TestERC20("Wrapped Bitcoin", "WBTC", 8);
-            HOST_WETH = new TestERC20("Wrapped Ether", "WETH", 18);
+            HOST_WETH = new TestERC20("Wrapped Ether", "WETH", 18); // TODO: make it a real WETH!
             TOKEN_ADMIN = address(this);
             GAS_ADMIN = address(this);
             SEQUENCER_ADMIN = address(this);