Skip to content

Commit 9c94713

Browse files
committed
Rebased
1 parent 3795c41 commit 9c94713

File tree

2 files changed

+29
-1
lines changed

2 files changed

+29
-1
lines changed

packages/ordeq/tests/snapshots/resolve/resolve_duplicate_node_objects.snapshot.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,28 @@ from ordeq._resolve import _resolve_module_to_nodes
77

88
_ = _resolve_module_to_nodes(duplicate_node_objects)
99

10+
```
11+
12+
## Output
13+
14+
```text
15+
ValueError: Module 'example_duplicates.duplicate_node_objects' contains duplicate keys for the same node ('y' and 'x')
16+
File "/packages/ordeq/src/ordeq/_resolve.py", line LINO, in _resolve_module_to_nodes
17+
raise ValueError(
18+
...<2 lines>...
19+
)
20+
21+
File "/packages/ordeq/tests/resources/resolve/resolve_duplicate_node_objects.py", line LINO, in <module>
22+
_ = _resolve_module_to_nodes(duplicate_node_objects)
23+
24+
File "<frozen runpy>", line LINO, in _run_code
25+
26+
File "<frozen runpy>", line LINO, in _run_module_code
27+
28+
File "<frozen runpy>", line LINO, in run_path
29+
30+
File "/packages/ordeq-test-utils/src/ordeq_test_utils/snapshot.py", line LINO, in run_module
31+
run_path(str(file_path), run_name="__main__")
32+
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
33+
1034
```

packages/ordeq/tests/snapshots/typing.snapshot.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ packages/ordeq/tests/resources/views/node_outputs_regular_func.py:8: note: d
1212
packages/ordeq/tests/resources/views/node_outputs_regular_func.py:8: note: def node(*, inputs: Sequence[Input[Any] | View[Any, Any]] | Input[Any] | View[Any, Any] = ..., outputs: Sequence[Output[Any]] | Output[Any], checks: Sequence[Input[Any] | Output[Any] | Node[Any, Any]] | Input[Any] | Output[Any] | Node[Any, Any] | Hashable | None = ..., **attributes: Any) -> Callable[[Callable[FuncParams, FuncReturns]], Node[FuncParams, FuncReturns]]
1313
packages/ordeq/tests/resources/views/node_outputs_regular_func.py:8: note: def node(*, inputs: Sequence[Input[Any] | View[Any, Any]] | Input[Any] | View[Any, Any] = ..., outputs: None = ..., checks: Sequence[Input[Any] | Output[Any] | Node[Any, Any]] | Input[Any] | Output[Any] | Node[Any, Any] | Hashable | None = ..., **attributes: Any) -> Callable[[Callable[FuncParams, FuncReturns]], View[FuncParams, FuncReturns]]
1414
packages/ordeq/tests/resources/runner/run_non_runnable.py:3: error: Argument 1 to "run" has incompatible type "float"; expected Module | Node[Any, Any] | str [arg-type]
15+
packages/ordeq/tests/resources/runner/run_io_equivalent.py:13: error: Cannot override final attribute "__eq__" (previously declared in base class "_WithEq") [misc]
16+
packages/ordeq/tests/resources/runner/run_io_equivalent.py:16: error: Cannot override final attribute "__hash__" (previously declared in base class "_WithEq") [misc]
1517
packages/ordeq/tests/resources/nodes/node_unexpected_output_type.py:6: error: No overload variant of "node" matches argument types "Input[str]", "Input[str]" [call-overload]
1618
packages/ordeq/tests/resources/nodes/node_unexpected_output_type.py:6: note: Possible overload variants:
1719
packages/ordeq/tests/resources/nodes/node_unexpected_output_type.py:6: note: def [FuncParams`-1, FuncReturns] node(func: Callable[FuncParams, FuncReturns], *, inputs: Sequence[Input[Any] | View[Any, Any]] | Input[Any] | View[Any, Any] | None = ..., outputs: Sequence[Output[Any]] | Output[Any], checks: Sequence[Input[Any] | Output[Any] | Node[Any, Any]] | Input[Any] | Output[Any] | Node[Any, Any] | Hashable | None = ..., **attributes: Any) -> Node[FuncParams, FuncReturns]
@@ -54,6 +56,8 @@ packages/ordeq/tests/resources/io/io_mixed_types_overloaded_save.py:46: error: N
5456
packages/ordeq/tests/resources/io/io_mixed_types_overloaded_save.py:46: note: Possible overload variants:
5557
packages/ordeq/tests/resources/io/io_mixed_types_overloaded_save.py:46: note: def save(self, data: str) -> Any
5658
packages/ordeq/tests/resources/io/io_mixed_types_overloaded_save.py:46: note: def save(self, data: bytes) -> Any
59+
packages/ordeq/tests/resources/io/io_eq_override.py:16: error: Cannot override final attribute "__eq__" (previously declared in base class "_WithEq") [misc]
60+
packages/ordeq/tests/resources/io/io_eq_override.py:19: error: Cannot override final attribute "__hash__" (previously declared in base class "_WithEq") [misc]
5761
packages/ordeq/tests/resources/hooks/invalid_typed_output_hook.py:5: error: Argument 1 of "before_output_save" is incompatible with supertype "ordeq._hook.OutputHook"; supertype defines the argument type as "Output[str]" [override]
5862
packages/ordeq/tests/resources/hooks/invalid_typed_output_hook.py:5: note: This violates the Liskov substitution principle
5963
packages/ordeq/tests/resources/hooks/invalid_typed_output_hook.py:5: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
@@ -89,4 +93,4 @@ packages/ordeq/tests/resources/views/standalone_view_df_filter.py:17: note:
8993
packages/ordeq/tests/resources/checks/check_store_invalid_records.py:16: error: Need type annotation for "processed_records" [var-annotated]
9094
packages/ordeq/tests/resources/checks/check_after_save.py:18: error: "Series[Any]" not callable [operator]
9195
packages/ordeq/tests/resources/views/view_query.py:5: error: Need type annotation for "connection" [var-annotated]
92-
Found 32 errors in 25 files (checked 301 source files)
96+
Found 36 errors in 27 files (checked 301 source files)

0 commit comments

Comments
 (0)