Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent file handle leaks from Compactor.write on errors #25724

Closed
davidby-influx opened this issue Dec 30, 2024 · 0 comments · Fixed by #25725
Closed

prevent file handle leaks from Compactor.write on errors #25724

davidby-influx opened this issue Dec 30, 2024 · 0 comments · Fixed by #25725

Comments

@davidby-influx
Copy link
Contributor

There are a number of code paths in Compactor.write which
on error can lead to leaked file handles to temporary files.
This, in turn, prevents the removal of the temporary files until
InfluxDB is rebooted, releasing the file handles.

@davidby-influx davidby-influx self-assigned this Dec 30, 2024
davidby-influx added a commit that referenced this issue Dec 30, 2024
There are a number of code paths in Compactor.write which
on error can lead to leaked file handles to temporary files.
This, in turn, prevents the removal of the temporary files until
InfluxDB is rebooted, releasing the file handles.

closes #25724
@davidby-influx davidby-influx linked a pull request Dec 31, 2024 that will close this issue
davidby-influx added a commit that referenced this issue Jan 3, 2025
There are a number of code paths in Compactor.write which
on error can lead to leaked file handles to temporary files.
This, in turn, prevents the removal of the temporary files until
InfluxDB is rebooted, releasing the file handles.

closes #25724
davidby-influx added a commit that referenced this issue Jan 3, 2025
There are a number of code paths in Compactor.write which
on error can lead to leaked file handles to temporary files.
This, in turn, prevents the removal of the temporary files until
InfluxDB is rebooted, releasing the file handles.

closes #25724

(cherry picked from commit e974165)

closes #25739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant