Skip to content

Commit 875bd95

Browse files
fix(artifacts): Change invalid Go duration format from days to hours in the docs (#87)
Replace invalid "7d" and "30d" duration formats with valid Go time.Duration format "168h" (7 days) and "720h" (30 days) respectively. Go's time.Duration parser does not recognize "d" as a valid unit - only ns, us/µs, ms, s, m, h. - Fix ARTIFACTS_RETENTION_MAX_AGE default in README template - Fix retention config in go-agent example Fixes #86 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Eden Reich <[email protected]>
1 parent 24b9a9f commit 875bd95

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

examples/go-agent.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ spec:
4141
outputPath: "/tmp/reports"
4242
templateDir: "/app/templates"
4343
maxFileSizeMB: "50"
44-
retention: "30d"
44+
retention: "720h"
4545
services:
4646
database:
4747
type: service

internal/templates/common/docs/README.md.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ The following custom configuration variables are available:
135135
| **Artifacts** | `ARTIFACTS_STORAGE_BUCKET_NAME` | MinIO/S3 bucket name | `artifacts` |
136136
| **Artifacts** | `ARTIFACTS_STORAGE_USE_SSL` | Use SSL for MinIO/S3 connections | `true` |
137137
| **Artifacts** | `ARTIFACTS_RETENTION_MAX_ARTIFACTS` | Max artifacts per task (0 = unlimited) | `5` |
138-
| **Artifacts** | `ARTIFACTS_RETENTION_MAX_AGE` | Max artifact age (0 = no age limit) | `7d` |
138+
| **Artifacts** | `ARTIFACTS_RETENTION_MAX_AGE` | Max artifact age (0 = no age limit) | `168h` |
139139
| **Artifacts** | `ARTIFACTS_RETENTION_CLEANUP_INTERVAL` | Cleanup frequency (0 = manual only) | `24h` |
140140
{{- end }}
141141
{{- if and .ADL.Spec.Server.Auth .ADL.Spec.Server.Auth.Enabled }}

0 commit comments

Comments
 (0)