Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_batch to batch_size in Agent class #173

Open
riddhipits opened this issue Feb 20, 2025 · 0 comments
Open

apply_batch to batch_size in Agent class #173

riddhipits opened this issue Feb 20, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@riddhipits
Copy link

Currently, the class uses a boolean parameter apply_batch to determine whether to apply batching to the ABCD etc tensors. I suggest replacing this boolean with a batch_size parameter, which would default to 1. This change would allow for more flexibility in handling batch sizes while maintaining backward compatibility. Setting the default value of batch_size to 1 ensures that users who do not wish to use batching can continue to work with the library without any changes to their existing code.

@conorheins conorheins added the enhancement New feature or request label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants