-
Notifications
You must be signed in to change notification settings - Fork 536
Svelte 5 Adapter based on #2586 #2677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
puRe1337
wants to merge
95
commits into
inertiajs:master
Choose a base branch
from
puRe1337:new-package-svelte-5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
8929a9f
feat(svelte5): add Svelte 5 adapter and test app
brodienguyen f4a305c
refactor(test-app): update imports to @inertiajs/svelte5
brodienguyen 2cddcf5
refactor(test-app): update to svelte5 page store usage
brodienguyen 0a4ab02
refactor(components): migrate to $props and $state
brodienguyen 2c77cc9
refactor(components): switch to children/fallback props
brodienguyen 9fd8b75
refactor(deferred-props): update fallback syntax
brodienguyen 05f05d8
refactor(events): use $page.url instead of page.url
brodienguyen 6815b1b
refactor(FormComponent): use snippet for children
brodienguyen 6b346fc
refactor(Deferred): improve reactivity in effect
brodienguyen d12b857
refactor(App): improve page state reactivity
brodienguyen fd1f177
refactor(FormComponent): wrap form content in snippet
brodienguyen ec49202
refactor(components): update event handler syntax
brodienguyen c891424
feat(form): expose isDirty and setError in Form
brodienguyen f353ab4
refactor(form): update Form usage to snippet block
brodienguyen b322570
refactor(form): update Form usage to snippet block
brodienguyen 232103a
refactor(FormComponent): update slot usage
brodienguyen acf6066
refactor(form): update Form usage and error display
brodienguyen 9e911e1
refactor(FormComponent): update Form usage
brodienguyen 935b917
feat(FormComponent): add email field to form
brodienguyen 8337de1
test(svelte): skip tests for svelte5 adapter
brodienguyen 073f47f
refactor(form): migrate useForm to Svelte runes
brodienguyen 9906982
refactor(FormHelper): remove $ prefix from form usage
brodienguyen 461cffc
refactor(FormHelper): remove $ prefix from form usage
brodienguyen e1bf42a
refactor(FormComponent): update Reset.svelte children
brodienguyen adb6a9b
refactor(FormComponent): use snippet for form children
brodienguyen 0d719a1
refactor(form): use snippet for form children
brodienguyen fef4783
fix(useForm): correct error handling in onError callback
brodienguyen fea83cf
fix(useForm): improve reactivity and reset logic
brodienguyen 2901ea6
fix(form): add id to error message div
brodienguyen f39a609
refactor(useForm): improve defaults update logic
brodienguyen bf61286
refactor(test-app): make window props reactive to page
brodienguyen 874815a
refactor(test-app): use $props in Svelte pages
brodienguyen 664c038
refactor(test-app): use $props in Svelte5 components
brodienguyen e5ed818
feat(useForm): add reactive getters for form data
brodienguyen bc59e37
refactor(remember): remove $ prefix from form references
brodienguyen b684a14
refactor(ManyGroups): use $props for prop destructuring
brodienguyen ae6817c
refactor(InstantReload): use $props for foo and bar
brodienguyen 57c25d7
refactor(test-app): use $props destructuring in pages
brodienguyen cdec571
refactor(form-helper): remove $ prefix from form usage
brodienguyen 0919055
refactor(WhenVisible): use #snippet blocks for slots
brodienguyen 5969cd1
refactor(test-app): use $props in Svelte components
brodienguyen af3cf0f
refactor(FormHelper): update form type to InertiaFormRunes
brodienguyen 351c05c
refactor(FormHelper): update to use InertiaFormRunes type
brodienguyen 720744c
refactor(DeepMergeProps): use $props and $state helpers
brodienguyen a351d97
fix(useForm): update defaults and remember logic
brodienguyen 0904ca9
refactor(useForm): improve Svelte 5 runes compatibility
brodienguyen a897d2e
test: skip tests for svelte5 package
brodienguyen fdc07f0
refactor(useForm): simplify and modernize form logic
brodienguyen cb60fff
refactor(form): migrate useForm to TypeScript store
brodienguyen da1be08
refactor(FormComponent): update error markup and layout
brodienguyen ef1bf65
refactor(svelte5): migrate usePrefetch to $state
brodienguyen 1c8dfe1
refactor(svelte5): rewrite useRemember for Svelte 5
brodienguyen 9bc6a48
fix(index): update imports for usePrefetch and useRemember
brodienguyen eed53a9
build(test-app): update Svelte and Vite dependencies
brodienguyen 1a0cb87
lint: run pnpm run format
brodienguyen 6ba2754
ci(workflows): add svelte5 to adapter matrix
brodienguyen a0107b9
Merge remote-tracking branch 'inertia/master' into new-package-svelte-5
puRe1337 ccc3d85
chore: update lock file
puRe1337 880260c
chore: update dependencies
puRe1337 353e03c
chore: update test-app packages and copied files from original svelte…
puRe1337 bd39ed2
refactor: migrate Render.svelte to Component and use RenderProps type…
puRe1337 86dc955
feat: purge page store completely and use state only
puRe1337 14bcd0a
refactor: use Component instead of ComponentType
puRe1337 d1c0f05
feat: migrated useForm to runes mode
puRe1337 9fc163a
chore: keep types in svelte5/index.ts of original package
puRe1337 afe3870
chore: types inside svelte/5links.ts and more syncing with current sv…
puRe1337 437cc90
fix: pass down a snapshot of current state to ensure core router can …
puRe1337 8778403
refactor: tidy up createInertiaApp
puRe1337 a374f8a
fix: dedupe axios version in lock file
puRe1337 b4ff8ea
fix: skip more test
puRe1337 43ae195
fix: App.svelte effect
puRe1337 22ead7e
refactor: tidy up Form.svelte
puRe1337 13a064d
feat: add InfiniteScroll but in runes style
puRe1337 f48fd8d
refactor: tidy up Link, WhenVisible
puRe1337 44f3cb3
chore: run sv migrate on test-app
puRe1337 c421a8a
refactor: tidy up WhenVisible component
puRe1337 7309b45
refactor: types in Deferred component & fix side-effects
puRe1337 9d1f527
refactor: dont take a snapshot of newPage inside page state
puRe1337 3ae5d95
refactor: tidyup PreseveEqualProps
puRe1337 8865267
chore: add missing Router component
puRe1337 2e3d86d
chore: add comment to resolveRenderProps
puRe1337 172ef40
chore: add type-check:test-app:svelte5 script to package.json
puRe1337 3d58470
fix: dont return mount
puRe1337 5ff46d3
chore: disable eslint on children in Grid test component
puRe1337 197ffac
fix: type errors
puRe1337 87e7a4b
format code-style
puRe1337 bca56f3
refactor: use attachment instead of manually handling
puRe1337 f031658
fix: set target version to ES2020 in build
puRe1337 f7255f2
fix(ci): prevent pnpm wildcard from matching both svelte and svelte5 …
puRe1337 900e72a
fix(ci): handle vue3 build in playwright workflow
puRe1337 a7a3fc5
fix: await setup in createInertiaApp
puRe1337 61f8b13
fix: improve nestedA comparison logic for preserveEqualProps
puRe1337 30f2814
feat: add missing 'dev:test-app:svelte5' script
puRe1337 26a0c70
feat: add lint script for svelte5 test app
puRe1337 1986f60
refactor: use types instead of any in PreserveEqualProps
puRe1337 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at this one.
While migrating more code to the Svelte 5 Runes style, I haven't found a cleaner solution for this case yet.
For this reason, a small workaround has been implemented. The linked comment explains the proxy behavior in more detail.