fix: preserve query parameters in test server responses #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found this issue whilst looking at the other recent deferred props issue, this one is nice and small though! The test server was using req.path instead of req.originalUrl, which stripped query parameters from the URL in Inertia responses. Just a test server issue in this case
Author
|
Ah I thought this would be a small one, but it breaks a lot of existing tests that are relying on the incorrect behaviour of the test server - I'm happy to fix but it would be a massive diff, let me know if you're interested in proceeding |
alexspeller
force-pushed
the
fix/test-server-preserve-query-params
branch
4 times, most recently
from
fc94229 to
8ff989c
Compare
alexspeller
force-pushed
the
fix/test-server-preserve-query-params
branch
from
8ff989c to
4b1a7f7
Compare
Author
|
Well if you want it I think this is all the changes that are needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this whilst looking at the other recent deferred props issue, this one is nice and small though!
The test server was using req.path instead of req.originalUrl, which stripped query parameters from the URL
Just a test server issue in this case, there was already a TODO in the code, but I think the extra tests are worthwhile to test that the correct query params are preserved for deferred requests?