[NSOC'26][GSSOC'26]Fix data nesting corruption in FirestoreCache update method#414
Open
diksha78dev wants to merge 2 commits into
Open
[NSOC'26][GSSOC'26]Fix data nesting corruption in FirestoreCache update method#414diksha78dev wants to merge 2 commits into
diksha78dev wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
hi @diksha78dev solve the conflits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template 🚀
Description
This PR resolves a data integrity bug in the custom in-memory
FirestoreCacheutility.When updating a document, the
update()method incorrectly spread the wrapper object{ data, timestamp }instead of the inner documentdata. This resulted in corrupted cache entries that nested the document underdata.dataand broke subsequentget()operations.Motivation: Restore data consistency for cached user profiles and optimize memory caching behavior.
Related Issue
Closes #386
Type of Change
Screenshots / Videos (if applicable)
Not applicable (logical cache layer bug fix).
Testing Done
npm run testnpm run lintnpm run buildhttp://localhost:5173)Checklist
Contributor Declaration