fix: prevent leaderboard rank numbers flashing wrong positions on initial load#570
Open
Priyanka0205-CSE wants to merge 2 commits into
Open
fix: prevent leaderboard rank numbers flashing wrong positions on initial load#570Priyanka0205-CSE wants to merge 2 commits into
Priyanka0205-CSE wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #552
Root Cause
The leaderboard uses Firestore
onSnapshotwhich fires twice on page load:The loading state was cleared after the first callback (cache), causing rank numbers to flash incorrect positions for 1-2 seconds before jumping to the correct order.
Fix
Added a
snapshot.metadata.fromCachecheck so the loading spinner is only hidden when data arrives from the Firestore server, not from cache.Change
src/pages/GitRank.jsx— wrapsetLoadingUsers(false)inif (!snapshot.metadata.fromCache)