Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import/order named not working with spread operator #3146

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UnderKoen
Copy link

Fixes #3145

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (341178d) to head (6f4f1c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3146      +/-   ##
==========================================
- Coverage   95.59%   92.06%   -3.53%     
==========================================
  Files          83       83              
  Lines        3629     3630       +1     
  Branches     1282     1283       +1     
==========================================
- Hits         3469     3342     -127     
- Misses        160      288     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb
Copy link
Member

ljharb commented Jan 17, 2025

We should only do this if node's cjs-module-lexer also recognizes it. Let's discuss in the issue.

@ljharb ljharb marked this pull request as draft January 17, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

import/order with named fails when exporting uses spread operator.
2 participants