Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config files can contain multiple seeds, even though only one is used #487

Open
alexdewar opened this issue Aug 12, 2024 · 2 comments
Open

Comments

@alexdewar
Copy link
Contributor

See:

// I copied this logic from the old code, but it seems strange to me. Why do we

Note that although seed is an array, we only ever read at most one value from it. If the array is empty or the property is missing altogether, the seed is automatically generated.

A better way to express this would be to make it so the seed can be either an integer or null. Not sure whether the property should be required or optional.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Health-GPS Aug 12, 2024
@alexdewar alexdewar changed the title Config files can (bizarrely) contain multiple seeds Config files can contain multiple seeds, even though only one is used Aug 12, 2024
@jamesturner246
Copy link
Contributor

That is weird. You say only the first seed is used and the rest discarded? Gross. Integer or null is good.

I'd personally make everything required and disable with null, but that's just me. Happy with what you choose.

@alexdewar
Copy link
Contributor Author

That is weird. You say only the first seed is used and the rest discarded? Gross. Integer or null is good.

Yeah, exactly.

I'd personally make everything required and disable with null, but that's just me. Happy with what you choose.

I think that's the right call too. Better to be explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants