-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UMBRELLA] Generalise form 'static' and 'dynamic' risk factor models #231
Labels
Comments
Merged
Is this related to #194? |
This was referenced Nov 6, 2023
Related, but opposite ideas. @israel-vieira was rightfully against this change because modularity of model components would decrease with such a change -- i.e. models would become more bloated. This change seeks to reverse that by having separate modules for each unit computation -- i.e. the opposite of what #194 proposes. I will close #194, to avoid confusion. |
This was referenced Nov 18, 2023
Merged
jamesturner246
changed the title
Generalise form 'static' and 'dynamic' risk factor models
[UMBRELLA] Generalise form 'static' and 'dynamic' risk factor models
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For context, in existing HealthGPS speak, static means initialise and dynamic means update.
The concept of the 'static' and the 'dynamic' risk factor models is already a little cloudy.
Some Dynamic models also do initialisation, and vice versa. Both model types have
generate_
andupdate_risk_factors
methods. So why not relax the restriction of having static and dynamic models, and just use thegenerate
andupdate
methods of both where appropriate?This would also allow us to create as many risk factor models as we like, and stop polluting our models with hacky 'extras' where needed.
Also perhaps some way of grouping these modules, akin to the current separation of risk factor, demographic, analysis classes.
Tasks
StaticLinear
#385The text was updated successfully, but these errors were encountered: