Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help maintaining #13

Open
cevhyruz opened this issue Oct 5, 2022 · 11 comments
Open

Help maintaining #13

cevhyruz opened this issue Oct 5, 2022 · 11 comments

Comments

@cevhyruz
Copy link

cevhyruz commented Oct 5, 2022

Hi! It seems that this repo has not been updated for quite some time inline with tmux. Im using tmux for a daily basis and If possible I would like to help maintain the project.

Should I just send a PR for starter?

@eggbean
Copy link

eggbean commented Oct 5, 2022

I you do be sure to check the file that it was originally based on, as it seems to have been updated more recently than this one.

https://github.com/Bash-it/bash-it/blob/master/completion/available/tmux.completion.bash

@cevhyruz
Copy link
Author

cevhyruz commented Oct 5, 2022

@eggbean Thanks! Will do.

@imomaliev
Copy link
Owner

@cevhyruz @eggbean Hi! I was planning to move this project under main bash-completion repo. There was discussion about this scop/bash-completion#81 but didn't get time to actually do it. @cevhyruz If you want to help kick-start this process, fill free to create PR directly in main bash-completion repo, I will be happy to help with it and review it.

@cevhyruz
Copy link
Author

cevhyruz commented Oct 10, 2022

@imomaliev Sorry for taking so long to respond, Just a quick question

Is there any reason why these tmux commands are the only ones with command completion? also, the options seem a bit incomplete or are they the only options supported at the time of the writing?

@imomaliev
Copy link
Owner

imomaliev commented Oct 10, 2022

@cevhyruz No reason. Just the ones that were present at the time of the completion script creation. Yes, they are outdated and in need of an update to actualize them. bash-completion has helper functions that could help automate this, so there will not be hard-coded options.

@cevhyruz
Copy link
Author

Thanks! I'll take a look at bash-completion codebase as starter

@vinismarques
Copy link

Would love to see the completion shown automatically with tmux. It really improves the experience.

@imomaliev
Copy link
Owner

imomaliev commented Mar 29, 2023

Would love to see the completion shown automatically with tmux. It really improves the experience.

@vinismarques hi! Tmux's team does not want to ship completion files as a part of tmux itself. Read more here
tmux/tmux#259
tmux/tmux@a33bb3e

So, most distributions just ship this completion script. I would like to merge this into bash-completion repo, but currently do not have time for this.

@Ge0rges
Copy link

Ge0rges commented Aug 28, 2023

The file previously mentioned is actually up to data with tux 2.7 at least, where as this repo is not. Just an FYI if considering contributing to the completion package.

https://github.com/Bash-it/bash-it/blob/master/completion/available/tmux.completion.bash

@ghost
Copy link

ghost commented Jan 22, 2024

Hello, what's the status on this? I wanted to contribute to scop/bash-completion for tmux and saw the whole upstream status / your repo / the link above. I would like help on this one.

@imomaliev
Copy link
Owner

@alexandre-julien Hi, I do not currently have time to maintain this project, it would be best if someone would work on adding tmux completion directly to bash-completion repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants