-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submit this to upstream bash-completion project #1
Comments
Hi. That's a grate idea. I was planning on doing so, after I cleaned up few things. So until then I leave this issue open as a reminder. |
Another project tried doing that recently in scop/bash-completion#81. It seems that bash-completion folks prefer people to try to merge to upstream projects first. |
@aprokop thanks for letting me know. I talked with tmux guys and it is clear that they don't want to include this to upstream. I will try to keep this script up to date with their upstream. |
Reviving this old issue to hopefully work towards resolving it. In scop/bash-completion#81, @scop recommends to "merge" the separate tmux bash-completion scripts that various people (@Boruch-Baum, @imomaliev, and @srsudar) in that issue offered up into a single file. Once a comprehensive tmux bash-completion script is settled upon and its code style adjusted to match the rest of scop/bash-completion, a PR should be made to add it to bash-completion. Additionally, a maintenance volunteer would be needed once merged into bash-completion. In other words, all that is needed to add tmux completion into bash-completion is community agreement, some code style clean-up, and a volunteer to maintain it once merged into bash-completion. If possible, the tmux bash-completion "merge" and code clean up should happen in this repository due to tmux's README pointing here. The link from tmux's README serves as approval from the tmux author, which will help when making a PR to scop/bash-completion. It seems that this "merge" could be as simple as selecting the most comprehensive of the tmux bash-completion scripts. Based on comments from the above linked issue, @Boruch-Baum seems confident their script is the most comprehensive and so I urge them to release it to the public (ideally by making a PR here). If @Boruch-Baum is unavailable, the current script in this repo will need to be cleaned up to match the code styles in scop/bash-completion and submitted as a PR there. Hopefully then we can all enjoy painless tmux completion and a single source of completion truth after years of fragmentation. I'm also volunteering to help clean up the code, make the PR, and maintain the script once merged into bash-completion unless someone else wishes to do so. |
Hi, @jackfletch. I am currently quite busy with a business trip, let me get back to in a couple of days |
Since tmux is very useful, it would be nice for tmux completion to be included in bash-completion repository.
Thanks.
The text was updated successfully, but these errors were encountered: