Skip to content

Commit f5e9720

Browse files
authored
Merge pull request #515 from immutable/fix/uwb-logs
[ID-3839] fix: uwb log level
2 parents fac8680 + 3246ee3 commit f5e9720

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

src/Packages/Passport/Runtime/ThirdParty/UnityWebBrowser/[email protected]/Runtime/Logging/DefaultUnityWebBrowserLogger.cs

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
using System;
99
using UnityEngine;
10+
using VoltstroStudios.UnityWebBrowser.Shared;
1011

1112
namespace VoltstroStudios.UnityWebBrowser.Logging
1213
{
@@ -18,32 +19,43 @@ public sealed class DefaultUnityWebBrowserLogger : IWebBrowserLogger
1819
private const string LoggingTag = "[UWB]";
1920

2021
private readonly ILogger logger;
22+
23+
private LogSeverity logSeverity;
2124

2225
/// <summary>
2326
/// A function that defines how sensitive data should be redacted.
2427
/// If null, no redaction is applied.
2528
/// </summary>
2629
public Func<string, string>? redactionHandler;
2730

28-
public DefaultUnityWebBrowserLogger(Func<string, string>? redactionHandler = null)
31+
public DefaultUnityWebBrowserLogger(LogSeverity logSeverity = LogSeverity.Info, Func<string, string>? redactionHandler = null)
2932
{
3033
logger = UnityEngine.Debug.unityLogger;
34+
this.logSeverity = logSeverity;
3135
this.redactionHandler = redactionHandler;
3236
}
3337

3438
public void Debug(object message)
3539
{
36-
logger.Log(LogType.Log, LoggingTag, redactIfRequired(message));
40+
if (ShouldLog(LogSeverity.Debug))
41+
logger.Log(LogType.Log, LoggingTag, redactIfRequired(message));
3742
}
3843

3944
public void Warn(object message)
4045
{
41-
logger.LogWarning(LoggingTag, redactIfRequired(message));
46+
if (ShouldLog(LogSeverity.Warn))
47+
logger.LogWarning(LoggingTag, redactIfRequired(message));
4248
}
4349

4450
public void Error(object message)
4551
{
46-
logger.LogError(LoggingTag, redactIfRequired(message));
52+
if (ShouldLog(LogSeverity.Error))
53+
logger.LogError(LoggingTag, redactIfRequired(message));
54+
}
55+
56+
private bool ShouldLog(LogSeverity severity)
57+
{
58+
return severity >= logSeverity;
4759
}
4860

4961
private object redactIfRequired(object message)

src/Packages/Passport/Runtime/ThirdParty/UnityWebBrowser/[email protected]/Runtime/UwbWebView.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,17 @@ public async UniTask Init(int engineStartupTimeoutMs, bool redactTokensInLogs, F
4343
webBrowserClient.noSandbox = true;
4444

4545
// Log level
46-
webBrowserClient.logSeverity = PassportLogger.CurrentLogLevel switch
46+
var logSeverity = PassportLogger.CurrentLogLevel switch
4747
{
4848
LogLevel.Debug => LogSeverity.Debug,
4949
LogLevel.Warn => LogSeverity.Warn,
5050
LogLevel.Error => LogSeverity.Error,
5151
_ => LogSeverity.Info
5252
};
53+
webBrowserClient.logSeverity = logSeverity;
5354

5455
// Logger
55-
webBrowserClient.Logger = new DefaultUnityWebBrowserLogger(redactionHandler: redactTokensInLogs ? redactionHandler : null);
56+
webBrowserClient.Logger = new DefaultUnityWebBrowserLogger(logSeverity: logSeverity, redactionHandler: redactTokensInLogs ? redactionHandler : null);
5657

5758
// Js
5859
webBrowserClient.jsMethodManager = new JsMethodManager { jsMethodsEnable = true };

0 commit comments

Comments
 (0)