fix: use byte array for stark key generation signature message

Replaces string-based signature message with raw bytes in stark
key generation to prevent encoding issues in non-English systems.

This aligns with the fix for wallet connection message encoding.

Author: brayansdt

packages/x-client/src/utils/stark/legacy/crypto/constants.ts

@@ -4,11 +4,21 @@ import BN from 'bn.js';
 import elliptic from 'elliptic';
 import hashJS from 'hash.js';
 
+import { toUtf8String } from 'ethers';
 import { constantPointsHex } from './points';
 import { Instruction, InstructionWithFee } from './types';
 
 const DEFAULT_ACCOUNT_MAPPING_KEY = 'STARKWARE_ACCOUNT_MAPPING';
-const DEFAULT_SIGNATURE_MESSAGE = 'Only sign this request if you’ve initiated an action with Immutable X.';
+// const DEFAULT_SIGNATURE_MESSAGE = 'Only sign this request if you’ve initiated an action with Immutable X.';
+// non-english systems may not encode this correctly
+const DEFAULT_SIGNATURE_BYTES = new Uint8Array([
+  79, 110, 108, 121, 32, 115, 105, 103, 110, 32, 116, 104, 105, 115, 32, 114,
+  101, 113, 117, 101, 115, 116, 32, 105, 102, 32, 121, 111, 117, 226, 128, 153,
+  118, 101, 32, 105, 110, 105, 116, 105, 97, 116, 101, 100, 32, 97, 110, 32,
+  97, 99, 116, 105, 111, 110, 32, 119, 105, 116, 104, 32, 73, 109, 109, 117,
+  116, 97, 98, 108, 101, 32, 88, 46,
+]);
+const DEFAULT_SIGNATURE_MESSAGE = toUtf8String(DEFAULT_SIGNATURE_BYTES);
 
 const DEFAULT_ACCOUNT_LAYER = 'starkex';
 const DEFAULT_ACCOUNT_APPLICATION = 'immutablex';
@@ -95,6 +105,7 @@ export {
   DEFAULT_ACCOUNT_INDEX,
   DEFAULT_ACCOUNT_LAYER,
   DEFAULT_ACCOUNT_MAPPING_KEY,
+  DEFAULT_SIGNATURE_BYTES,
   DEFAULT_SIGNATURE_MESSAGE,
   instructionEncodingMap,
   MAX_ECDSA_BN,

packages/x-client/src/utils/stark/starkCurve.ts

@@ -6,7 +6,7 @@ import * as encUtils from 'enc-utils';
 // eslint-disable-next-line @typescript-eslint/naming-convention
 import BN from 'bn.js';
 import { hdkey } from '@ethereumjs/wallet';
-import { Signature, Signer, toUtf8Bytes } from 'ethers';
+import { Signature, Signer } from 'ethers';
 import { createStarkSigner } from './starkSigner';
 import * as legacy from './legacy/crypto';
 import { getStarkPublicKeyFromImx } from './getStarkPublicKeyFromImx';
@@ -286,7 +286,7 @@ export async function generateLegacyStarkPrivateKey(
   signer: Signer,
 ): Promise<string> {
   const address = (await signer.getAddress()).toLowerCase();
-  const signature = await signer.signMessage(toUtf8Bytes(legacy.DEFAULT_SIGNATURE_MESSAGE));
+  const signature = await signer.signMessage(legacy.DEFAULT_SIGNATURE_BYTES);
   const seed = Signature.from(signature).s;
   const path = legacy.getAccountPath(
     legacy.DEFAULT_ACCOUNT_LAYER,

packages/x-provider/src/imx-wallet/imxWallet.ts

@@ -1,8 +1,6 @@
 import { Environment } from '@imtbl/config';
 import {
   BrowserProvider,
-  getBytes,
-  toUtf8Bytes,
   toUtf8String,
 } from 'ethers';
 import {
@@ -21,7 +19,14 @@ import { messageResponseListener } from './messageResponseListener';
 import { ImxSigner } from './ImxSigner';
 import { getOrSetupIFrame } from './imxWalletIFrame';
 
-const DEFAULT_CONNECTION_MESSAGE = 'Only sign this request if you’ve initiated an action with Immutable X.';
+// "Only sign this request if you've initiated an action with Immutable X."
+const DEFAULT_CONNECTION_BYTES = new Uint8Array([
+  79, 110, 108, 121, 32, 115, 105, 103, 110, 32, 116, 104, 105, 115, 32, 114,
+  101, 113, 117, 101, 115, 116, 32, 105, 102, 32, 121, 111, 117, 226, 128, 153,
+  118, 101, 32, 105, 110, 105, 116, 105, 97, 116, 101, 100, 32, 97, 110, 32,
+  97, 99, 116, 105, 111, 110, 32, 119, 105, 116, 104, 32, 73, 109, 109, 117,
+  116, 97, 98, 108, 101, 32, 88, 46,
+]);
 const CONNECTION_FAILED_ERROR = 'The L2 IMX Wallet connection has failed';
 
 export async function connect(
@@ -31,13 +36,11 @@ export async function connect(
   const l1Signer = await l1Provider.getSigner();
   const address = await l1Signer.getAddress();
 
-  console.log('DEFAULT_CONNECTION_MESSAGE', { message: DEFAULT_CONNECTION_MESSAGE });
-  console.log('toUtf8Bytes.toString()', { toUtf8Bytes: toUtf8Bytes(DEFAULT_CONNECTION_MESSAGE).toString() });
+  // log read message here
+  console.log('DEFAULT_CONNECTION_BYTES.toString()', { bytes: DEFAULT_CONNECTION_BYTES.toString() });
+  console.log('DEFAULT_CONNECTION_BYTES.toUtf8String()', { bytes: toUtf8String(DEFAULT_CONNECTION_BYTES) });
 
-  console.log('toUtf8String 1', { toUtf8String: toUtf8String(toUtf8Bytes(DEFAULT_CONNECTION_MESSAGE)) });
-  console.log('toUtf8String 2', { toUtf8String: toUtf8String(getBytes(toUtf8Bytes(DEFAULT_CONNECTION_MESSAGE))) });
-
-  const signature = await l1Signer.signMessage(toUtf8Bytes(DEFAULT_CONNECTION_MESSAGE));
+  const signature = await l1Signer.signMessage(DEFAULT_CONNECTION_BYTES);
   const iframe = await getOrSetupIFrame(env);
 
   return new Promise((resolve, reject) => {