Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we handle redirection #39

Open
tatchi opened this issue Aug 28, 2023 · 1 comment
Open

Should we handle redirection #39

tatchi opened this issue Aug 28, 2023 · 1 comment

Comments

@tatchi
Copy link
Contributor

tatchi commented Aug 28, 2023

I was testing the cohttp client with the jaeger all in one image. I set http://localhost:4318/ as the config.url, which makes the client to send traces to http://localhost:4318//v1/traces (notice the double //. Also see #38).

I didn't notice any errors in the terminal, but no traces showed up. It turns out that this is because a 301 redirect to /v1/traces was returned, and we do not handle redirects in the code.

I think we should handle redirects or at least fail/log something out to the console. wdyt?

@c-cube
Copy link
Member

c-cube commented Aug 28, 2023

I think the ocurl backend does handle redirections. But good point about the cohttp client.

And yes, logging to stderr is a good idea. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants