Fix more PHP 8 issues

iherwig · iherwig · commit 3b82dced7478 · 2023-02-24T22:42:56.000+01:00
diff --git a/src/wcmf/lib/presentation/link/LinkProcessor.php b/src/wcmf/lib/presentation/link/LinkProcessor.php
@@ -185,15 +185,15 @@ protected static function convertInternalLink($url, LinkProcessorStrategy $strat
       }
       $anchorOID = InternalLink::getAnchorOID($url);
       if ($anchorOID != null) {
-        if (strrpos($urlConv) !== 0) {
+        if (strrpos($urlConv, '#') !== 0) {
           $urlConv .= '#';
         }
         $urlConv .= $anchorOID;
       }
       else {
         $anchorName = InternalLink::getAnchorName($url);
         if ($anchorName != null) {
-          if (strrpos($urlConv) !== 0) {
+          if (strrpos($urlConv, '#') !== 0) {
             $urlConv .= '#';
           }
           $urlConv .= $anchorName;

Original file line number	Diff line number	Diff line change
`@@ -185,15 +185,15 @@ protected static function convertInternalLink($url, LinkProcessorStrategy $strat`
`185`	`185`	`}`
`186`	`186`	`$anchorOID = InternalLink::getAnchorOID($url);`
`187`	`187`	`if ($anchorOID != null) {`
`188`		`- if (strrpos($urlConv) !== 0) {`
	`188`	`+ if (strrpos($urlConv, '#') !== 0) {`
`189`	`189`	`$urlConv .= '#';`
`190`	`190`	`}`
`191`	`191`	`$urlConv .= $anchorOID;`
`192`	`192`	`}`
`193`	`193`	`else {`
`194`	`194`	`$anchorName = InternalLink::getAnchorName($url);`
`195`	`195`	`if ($anchorName != null) {`
`196`		`- if (strrpos($urlConv) !== 0) {`
	`196`	`+ if (strrpos($urlConv, '#') !== 0) {`
`197`	`197`	`$urlConv .= '#';`
`198`	`198`	`}`
`199`	`199`	`$urlConv .= $anchorName;`