Commit 70795a6
Address PR #451 R1 review (1 P2, 1 P3)
P2 (Documentation/Tests): the "PDF reviewed" line referenced
papers/goodman-bacon.pdf, which is under the gitignored /papers/
directory and therefore not reproducible from the tree. Replaced
the local-path citation with the Journal of Econometrics version
referenced by DOI 10.1016/j.jeconom.2021.03.014, with an explicit
note that local PDFs are gitignored. This matches the pattern in
rambachan-roth-2023-review.md and wooldridge-2023-review.md
(DOI/URL citations) rather than the local-path pattern in the
older butts/clarke/conley reviews.
P3 (Maintainability): the "source-of-truth target" / "authoritative
reference for the audit work" framing at L14 created dual contracts
with REGISTRY.md until the audit PR lands. Reworded to:
- "proposed replacement text for a future REGISTRY update"
- explicit statement that REGISTRY.md remains the sole authoritative
contract until the audit PR lands
- pointer to the TODO.md row tracking that audit
No estimator, weighting, variance, or inference code changed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 8f6ca46 commit 70795a6
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
0 commit comments