Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Easy fix] Users can delete the bot's quotes with the ?mix command #215

Closed
le-potate opened this issue Nov 27, 2019 · 1 comment · May be fixed by #468
Closed

[BUG] [Easy fix] Users can delete the bot's quotes with the ?mix command #215

le-potate opened this issue Nov 27, 2019 · 1 comment · May be fixed by #468
Assignees
@le-potate
Labels
bug Something isn't working

Comments

@le-potate
Copy link
Contributor

Bug Description

It is possible to use the ?mix or ?bac commands to make Marty delete his own quotes

Reproduction Steps

  1. ?lq @marty
  2. Click on the delete button
  3. ?mix 15 

Reason behind Bug:

Quote deletion should ignore marty. Easy to do since there's already a line to ignore users that didn't write the quote
@le-potate le-potate added the bug Something isn't working label Nov 27, 2019
@le-potate le-potate self-assigned this Sep 7, 2020
le-potate added a commit that referenced this issue Aug 31, 2021
@le-potate
Various changes to quotes (including mod deletion)
2a70f3f 
Moderators can now delete quotes when they are quoted, from the list of quotes of a user, from the allq command, and delete all quotes from a certain user using ?purgequotes

rebuild_mc has been added everywhere where quotes are deleted

the delete emoji in ?lq can now only be clicked by the quote list author or by a mod (whereas any users used to be able to click it before and start the delete prompt, but only the author could use the prompt). The person who clicks the reacts is also the only one that can then delete a quote. By doing this, this fixes #215, since Marty cannot even start the prompt anymore. (The check that the message wasn't written by the bot was still added in case and might be useful in case Marty can ever react on other people's messages).
@le-potate le-potate mentioned this issue Aug 31, 2021
Open
3 tasks
@le-potate
Copy link
Contributor Author

was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@le-potate le-potate

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various changes to quotes (including mod deletion) idoneam/Canary
1 participant
@le-potate