Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support vapor mixture modeling in THM #28335

Open
joshuahansel opened this issue Aug 8, 2024 · 2 comments · May be fixed by #30125
Open

Support vapor mixture modeling in THM #28335

joshuahansel opened this issue Aug 8, 2024 · 2 comments · May be fixed by #30125
Assignees
@joshuahansel
Labels
C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module T: task An enhancement to the software.

Comments

@joshuahansel
Copy link
Contributor

Motivation

Some problems, such as those featuring heat pipes, involve the presence of multiple gases in the same space.

Design

This includes:

  • New single-phase flow model in THM to support vapor mixtures (or generalization of existing single-phase flow channel)
  • Improvements to vapor mixture fluid properties as necessary.

Impact

Greater capability: new physics and properties.
@joshuahansel joshuahansel added T: task An enhancement to the software. C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module labels Aug 8, 2024
@joshuahansel joshuahansel self-assigned this Aug 8, 2024
@GiudGiud
Copy link
Contributor

GiudGiud commented Aug 9, 2024

What's the timeline on this? Could we try to make the SinglePhaseFlowModel a Physics before then?

@joshuahansel
Copy link
Contributor Author

It's a prereq for next FY's Sockeye milestone. Yeah, I'll try to make that a Physics.

joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 15, 2024
@joshuahansel
Improved doc for IdealRealGasMixtureFluidProperties
33e8297 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 15, 2024
@joshuahansel
Added generic methods to VaporMixtureFluidProperties
155a2f3 
- mixtureMolarMass(molar_fractions, molar_masses)
- massFractionsFromMolarFractions(molar_fractions, molar_masses)

Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 15, 2024
@joshuahansel
Added TwoPhaseNCGPartialPressureFluidProperties
e6fe40b 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 15, 2024
@joshuahansel
Added saturation mass fraction option to FluidPropertiesInterrogator
9aaadd8 
Refs idaholab#28335
@joshuahansel joshuahansel mentioned this issue Aug 16, 2024
Merged
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 19, 2024
@joshuahansel
Addressed review
e994cf5 
- Mentioned ideal gas mixture in doc
- Clarified arg error message in function
- Fixed hidden Function::value

Refs idaholab#28335
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this issue Aug 28, 2024
@joshuahansel
Improved doc for IdealRealGasMixtureFluidProperties
deffccb 
Refs idaholab#28335
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this issue Aug 28, 2024
@joshuahansel
Added generic methods to VaporMixtureFluidProperties
d22869e 
- mixtureMolarMass(molar_fractions, molar_masses)
- massFractionsFromMolarFractions(molar_fractions, molar_masses)

Refs idaholab#28335
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this issue Aug 28, 2024
@joshuahansel
Added TwoPhaseNCGPartialPressureFluidProperties
2f9bbe1 
Refs idaholab#28335
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this issue Aug 28, 2024
@joshuahansel
Added saturation mass fraction option to FluidPropertiesInterrogator
a489494 
Refs idaholab#28335
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this issue Aug 28, 2024
@joshuahansel
Addressed review
04b101c 
- Mentioned ideal gas mixture in doc
- Clarified arg error message in function
- Fixed hidden Function::value

Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Nov 12, 2024
@joshuahansel
Added some virtuals for single-phase flow
8efbec3 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Nov 12, 2024
@joshuahansel
Inherited NonADFunctorInterface in InitialConditionBase
2f3f18d 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Dec 3, 2024
@joshuahansel
Added some virtuals for single-phase flow
db77b9b 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Dec 3, 2024
@joshuahansel
Inherited NonADFunctorInterface in InitialConditionBase
6421dfd 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Dec 3, 2024
@joshuahansel
Some single-phase flow model cleanup
7bbd09a 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Dec 5, 2024
@joshuahansel
Added Davis wave speed option to ADNumericalFlux3EqnHLLC
79455a2 
This will be the wave speed used by the gas mix version, so
this option is added for testing/comparison.

Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Dec 5, 2024
@joshuahansel
Refactored base class out of ADNumericalFlux3EqnBase
5df26d8 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Dec 5, 2024
@joshuahansel
Refactored single-phase numerical flux tests
1bf5919 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Dec 5, 2024
@joshuahansel
Added gas mixture numerical flux
98f1139 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Dec 5, 2024
@joshuahansel
Added theory for gas mixture flow model
6857063 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Dec 5, 2024
@joshuahansel
Added initial conditions for the gas mixture flow model
e6849a1 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 10, 2025
@joshuahansel
Added some virtuals for single-phase flow
2903481 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 10, 2025
@joshuahansel
Inherited NonADFunctorInterface in InitialConditionBase
1c4638f 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 10, 2025
@joshuahansel
Some single-phase flow model cleanup
84ab023 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added some virtuals for single-phase flow
c9b72a4 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Some single-phase flow model cleanup
cb29830 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added Davis wave speed option to ADNumericalFlux3EqnHLLC
c16b31e 
This will be the wave speed used by the gas mix version, so
this option is added for testing/comparison.

Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Refactored base class out of ADNumericalFlux3EqnBase
12c98e4 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Refactored single-phase numerical flux tests
9db6b77 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added theory for gas mixture flow model
87db6d6 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added gas mixture numerical flux
ccd0271 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added initial conditions for the gas mixture flow model
3156fd7 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added aux for the gas mixture flow model
2f02ee5 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added fluid properties material for gas mixture flow model
1732796 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added slope reconstruction material for gas mixture flow model
535cc5f 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Factored out base class from single-phase flow model/channel
71629ca 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added FlowChannelGasMix
408c85d 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Generalized heat transfer components
d448e0c 
These now use FlowChannel1PhaseBase instead of only
FlowChannel1Phase.

Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Handled sub-triple-point temperatures in saturation mass fraction
57c14be 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Added FlowChannelGasMix
8865ab4 
Closes idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Generalized heat transfer components
d9eb7fd 
These now use FlowChannel1PhaseBase instead of only
FlowChannel1Phase.

Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 18, 2025
@joshuahansel
Handled sub-triple-point temperatures in saturation mass fraction
4c9391a 
Refs idaholab#28335
@joshuahansel joshuahansel linked a pull request Mar 18, 2025 that will close this issue
Draft
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Added rho_from_p_T and e_from_p_rho to ideal gas mixture
d373ad7 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Added gas mixture numerical flux
49399e6 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Added initial conditions for the gas mixture flow model
66509b4 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Added aux for the gas mixture flow model
51995f8 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Added fluid properties material for gas mixture flow model
5d31a2c 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Added slope reconstruction material for gas mixture flow model
6110fb6 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Factored out base class from single-phase flow model/channel
540af1a 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Added FlowChannelGasMix
e5253f8 
Closes idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Generalized heat transfer components
fd9493f 
These now use FlowChannel1PhaseBase instead of only
FlowChannel1Phase.

Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Handled sub-triple-point temperatures in saturation mass fraction
46f2830 
Refs idaholab#28335
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 19, 2025
@joshuahansel
Handled sub-triple-point temperatures in saturation mass fraction
31f0f72 
Refs idaholab#28335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuahansel joshuahansel

Labels
C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added gas mixture flow model in THM joshuahansel/moose
2 participants
@joshuahansel @GiudGiud