Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberedObjectCollection append_renumber ignores negative numbers #690

Open
MicahGale opened this issue Mar 12, 2025 · 0 comments
Open

NumberedObjectCollection append_renumber ignores negative numbers #690

MicahGale opened this issue Mar 12, 2025 · 0 comments
Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". low priority

Comments

@MicahGale
Copy link
Collaborator

Describe the bug

NumberedObjectCollection.append_renumber (e.g., Cells.append_renumber) considers -1 a valid number. This is the placeholder value, that shouldn't be used.

To Reproduce

import montepy
mat= montepy.Material()
mats = montepy.materials.Materials()
mats.append_renumber(mat)
print(mat.number)

yields

-1

Version

  • Version 0.5.3, 1.0.0a1
@MicahGale MicahGale added bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". low priority labels Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MicahGale