-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
Description
Detailed Description
As tumour grading is not applicable to certain cancers, for example blood cancers:
- T-cell Lymphoma (EUPTCL-DE)
- Multiple Myeloma (MM-KR)
Programs would like to submitNot applicablefortumour_grading_systemandtumour_grade.
Becausetumour_gradeis depend ontumour_grading_system, whentumour_grading_system=Not applicable,tumour_gradeshall beNot applicableas well.
After we implement this, we need to modify clinical validation rules to allow tumour_grade = Not applicable, otherwise users will see clinical validation errors, because tumour_grade is a required field.
Note that this is NOT a clinical exception, as it's a valid scientific case.
The clinical changes will be done here: icgc-argo/argo-clinical#805
Exit Criteria
when users submit the following combo to clinical system
| tumour_grading_system | tumour_grade |
|---|---|
| Not applicable | Not applicable |
there should be no dictionary error, this should be a valid case.
Possible Implementation
- Add a new enum value
Not applicableto the permissible list oftumour_grading_system. - Add a new enum value
Not applicableto the permissible list oftumour_grade. - Modify the
tumour_grade's validation scrip to allowNot applicablevalue whentumour_grading_system=Not applicable.
Reactions are currently unavailable