Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize parameters with scenarios #139

Open
vadim0x60 opened this issue Nov 21, 2023 · 0 comments
Open

Synchronize parameters with scenarios #139

vadim0x60 opened this issue Nov 21, 2023 · 0 comments

Comments

@vadim0x60
Copy link

vadim0x60 commented Nov 21, 2023

If, when I initialize BoptestGymEnv, I select a scenario like this:

env = BoptestGymEnv(
  start_time            = 0,
  scenario              = {'electricity_price': 'dynamic', 'time_period': 'peak_heat_day'})

this leads to errors and unstable behavior, because 'peak_heat_day' scenario includes a start_time and this start_time is not zero. So the request above (create a 'peak_heat_day' scenario with a start_time of 0) is inconsistent, however BoptestGymEnv doesn't raise any exception immediately, instead what happens is:

  • the start time in dockerized BOPTEST simulator is set to 1382400, as specified in peak_heat_day scenario
  • the start time variable in BOPTEST gym is set to 0 as specified in the constructor
  • this conflict leads to hard to catch bugs down the line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant