[CI] Fixed new phpstan issues (#1708)

Author: ViniTou

phpstan-baseline.neon

@@ -582,12 +582,6 @@ parameters:
 			count: 1
 			path: src/bundle/Controller/LinkManagerController.php
 
-		-
-			message: '#^Cannot access offset 0 on iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Relation\>\.$#'
-			identifier: offsetAccess.nonOffsetAccessible
-			count: 1
-			path: src/bundle/Controller/LocationController.php
-
 		-
 			message: '#^Cannot access property \$contentId on Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Location\|null\.$#'
 			identifier: property.nonObject
@@ -13152,12 +13146,6 @@ parameters:
 			count: 1
 			path: src/lib/UI/Dataset/VersionsDataset.php
 
-		-
-			message: '#^Parameter \#2 \$array of function array_map expects array, iterable\<int, Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\VersionInfo\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/lib/UI/Dataset/VersionsDataset.php
-
 		-
 			message: '#^Call to an undefined method Ibexa\\Contracts\\Core\\Repository\\PermissionResolver\:\:sudo\(\)\.$#'
 			identifier: method.notFound
@@ -13428,6 +13416,12 @@ parameters:
 			count: 1
 			path: src/lib/UI/Value/ValueFactory.php
 
+		-
+			message: '#^Strict comparison using \!\=\= between string and null will always evaluate to true\.$#'
+			identifier: notIdentical.alwaysTrue
+			count: 1
+			path: src/lib/UI/Value/ValueFactory.php
+
 		-
 			message: '#^Method Ibexa\\AdminUi\\UniversalDiscovery\\ConfigResolver\:\:getConfig\(\) has parameter \$context with no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue

src/bundle/Controller/LocationController.php

@@ -210,7 +210,14 @@ public function copyAction(Request $request): Response
                     $locationCreateStruct
                 );
 
-                $newLocation = $this->locationService->loadLocation($copiedContent->contentInfo->mainLocationId);
+                $mainLocationId = $copiedContent->getContentInfo()->getMainLocationId();
+                if ($mainLocationId === null) {
+                    throw new InvalidArgumentException(
+                        'mainLocationId',
+                        'Copied content does not have a main location'
+                    );
+                }
+                $newLocation = $this->locationService->loadLocation($mainLocationId);
 
                 $this->notificationHandler->success(
                     /** @Desc("'%name%' copied to '%location%'") */

src/lib/EventListener/ViewTemplatesListener.php

@@ -52,7 +52,7 @@ public function setViewTemplates(PreContentViewEvent $event): void
     }
 
     /**
-     * @return string[]
+     * @return array<class-string, string>
      */
     private function getTemplatesMap(): array
     {

tests/bundle/DependencyInjection/Configuration/Parser/SubtreeOperationsTest.php

@@ -23,7 +23,7 @@ final class SubtreeOperationsTest extends TestCase
     private ContextualizerInterface $contextualizer;
 
     /**
-     * @return array<string, array{int}>
+     * @return iterable<string, array{int}>
      */
     public function getExpectedCopySubtreeLimit(): iterable
     {