Skip to content

Commit 2016a69

Browse files
authored
IBX-10286: Fix Multilevel Popup Menu XSS
1 parent e34cb0c commit 2016a69

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/bundle/Resources/public/js/scripts/core/multilevel.popup.menu.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
(function (global, doc, ibexa, Popper) {
2+
const { escapeHTML } = ibexa.helpers.text;
3+
const { dangerouslyInsertAdjacentHTML } = ibexa.helpers.dom;
4+
25
class MultilevelPopupMenu {
36
constructor(config) {
47
this.container = config.container;
@@ -359,9 +362,11 @@
359362
const itemTemplate = !!href ? itemTemplateLink : itemTemplateBtn;
360363

361364
const container = doc.createElement('div');
362-
const renderedItem = itemTemplate.replaceAll('{{ label }}', label).replaceAll('{{ sublabel }}', sublabel);
365+
const renderedItem = itemTemplate
366+
.replaceAll('{{ label }}', escapeHTML(label))
367+
.replaceAll('{{ sublabel }}', escapeHTML(sublabel));
363368

364-
container.insertAdjacentHTML('beforeend', renderedItem);
369+
dangerouslyInsertAdjacentHTML(container, 'beforeend', renderedItem);
365370

366371
const newItemElement = container.querySelector('.ibexa-popup-menu__item');
367372
const newItemContentElement = newItemElement.querySelector('.ibexa-popup-menu__item-content');

0 commit comments

Comments
 (0)